DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/bond: fix initialization error
@ 2018-11-13 16:46 Radu Nicolau
  2018-11-27 18:57 ` Chas Williams
  0 siblings, 1 reply; 3+ messages in thread
From: Radu Nicolau @ 2018-11-13 16:46 UTC (permalink / raw)
  To: dev; +Cc: declan.doherty, chas3, Radu Nicolau, stable

Queue setup will fail if called before adding slaves.

Fixes: 7a0665940fa8 ("net/bonding: inherit descriptor limits from slaves")
Cc: stable@dpdk.org

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
 examples/bond/main.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/examples/bond/main.c b/examples/bond/main.c
index b282e68..65f3c39 100644
--- a/examples/bond/main.c
+++ b/examples/bond/main.c
@@ -243,6 +243,13 @@ bond_port_init(struct rte_mempool *mbuf_pool)
 		rte_exit(EXIT_FAILURE, "port %u: rte_eth_dev_adjust_nb_rx_tx_desc "
 				"failed (res=%d)\n", BOND_PORT, retval);
 
+	for (i = 0; i < slaves_count; i++) {
+		if (rte_eth_bond_slave_add(BOND_PORT, slaves[i]) == -1)
+			rte_exit(-1, "Oooops! adding slave (%u) to bond (%u) failed!\n",
+					slaves[i], BOND_PORT);
+
+	}
+
 	/* RX setup */
 	rxq_conf = dev_info.default_rxconf;
 	rxq_conf.offloads = local_port_conf.rxmode.offloads;
@@ -263,13 +270,6 @@ bond_port_init(struct rte_mempool *mbuf_pool)
 		rte_exit(retval, "port %u: TX queue 0 setup failed (res=%d)",
 				BOND_PORT, retval);
 
-	for (i = 0; i < slaves_count; i++) {
-		if (rte_eth_bond_slave_add(BOND_PORT, slaves[i]) == -1)
-			rte_exit(-1, "Oooops! adding slave (%u) to bond (%u) failed!\n",
-					slaves[i], BOND_PORT);
-
-	}
-
 	retval  = rte_eth_dev_start(BOND_PORT);
 	if (retval < 0)
 		rte_exit(retval, "Start port %d failed (res=%d)", BOND_PORT, retval);
-- 
2.7.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/bond: fix initialization error
  2018-11-13 16:46 [dpdk-dev] [PATCH] examples/bond: fix initialization error Radu Nicolau
@ 2018-11-27 18:57 ` Chas Williams
  2018-11-28 10:38   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Chas Williams @ 2018-11-27 18:57 UTC (permalink / raw)
  To: dev



On 11/13/2018 11:46 AM, Radu Nicolau wrote:
> Queue setup will fail if called before adding slaves.
> 
> Fixes: 7a0665940fa8 ("net/bonding: inherit descriptor limits from slaves")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>

Acked-by: Chas Williams <chas3@att.com>

> ---
>   examples/bond/main.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/examples/bond/main.c b/examples/bond/main.c
> index b282e68..65f3c39 100644
> --- a/examples/bond/main.c
> +++ b/examples/bond/main.c
> @@ -243,6 +243,13 @@ bond_port_init(struct rte_mempool *mbuf_pool)
>   		rte_exit(EXIT_FAILURE, "port %u: rte_eth_dev_adjust_nb_rx_tx_desc "
>   				"failed (res=%d)\n", BOND_PORT, retval);
>   
> +	for (i = 0; i < slaves_count; i++) {
> +		if (rte_eth_bond_slave_add(BOND_PORT, slaves[i]) == -1)
> +			rte_exit(-1, "Oooops! adding slave (%u) to bond (%u) failed!\n",
> +					slaves[i], BOND_PORT);
> +
> +	}
> +
>   	/* RX setup */
>   	rxq_conf = dev_info.default_rxconf;
>   	rxq_conf.offloads = local_port_conf.rxmode.offloads;
> @@ -263,13 +270,6 @@ bond_port_init(struct rte_mempool *mbuf_pool)
>   		rte_exit(retval, "port %u: TX queue 0 setup failed (res=%d)",
>   				BOND_PORT, retval);
>   
> -	for (i = 0; i < slaves_count; i++) {
> -		if (rte_eth_bond_slave_add(BOND_PORT, slaves[i]) == -1)
> -			rte_exit(-1, "Oooops! adding slave (%u) to bond (%u) failed!\n",
> -					slaves[i], BOND_PORT);
> -
> -	}
> -
>   	retval  = rte_eth_dev_start(BOND_PORT);
>   	if (retval < 0)
>   		rte_exit(retval, "Start port %d failed (res=%d)", BOND_PORT, retval);
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/bond: fix initialization error
  2018-11-27 18:57 ` Chas Williams
@ 2018-11-28 10:38   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-11-28 10:38 UTC (permalink / raw)
  To: Chas Williams, dev

On 11/27/2018 6:57 PM, Chas Williams wrote:
> 
> 
> On 11/13/2018 11:46 AM, Radu Nicolau wrote:
>> Queue setup will fail if called before adding slaves.
>>
>> Fixes: 7a0665940fa8 ("net/bonding: inherit descriptor limits from slaves")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> 
> Acked-by: Chas Williams <chas3@att.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-28 10:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-13 16:46 [dpdk-dev] [PATCH] examples/bond: fix initialization error Radu Nicolau
2018-11-27 18:57 ` Chas Williams
2018-11-28 10:38   ` Ferruh Yigit

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git