* [dpdk-dev] [PATCH] net/ena: cleaning HW IO rings configuration
@ 2018-11-14 9:59 Rafal Kozik
2018-11-16 10:56 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Rafal Kozik @ 2018-11-14 9:59 UTC (permalink / raw)
To: dev; +Cc: mw, mk, gtzalik, evgenys, matua, igorch, Rafal Kozik
When queues are stoped release tx buffers.
During start initialize array of empty
tx/rx reqs with default values.
Fixes: df238f84c0a2 ("net/ena: recreate HW IO rings on start and stop")
Signed-off-by: Rafal Kozik <rk@semihalf.com>
Acked-by: Michal Krawczyk <mk@semihalf.com>
---
drivers/net/ena/ena_ethdev.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 05a4fbe..3690afe 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1096,6 +1096,7 @@ static int ena_create_io_queue(struct ena_ring *ring)
{ ENA_ADMIN_PLACEMENT_POLICY_HOST,
0, 0, 0, 0, 0 };
uint16_t ena_qid;
+ unsigned int i;
int rc;
adapter = ring->adapter;
@@ -1106,10 +1107,14 @@ static int ena_create_io_queue(struct ena_ring *ring)
ctx.direction = ENA_COM_IO_QUEUE_DIRECTION_TX;
ctx.mem_queue_type = ena_dev->tx_mem_queue_type;
ctx.queue_size = adapter->tx_ring_size;
+ for (i = 0; i < ring->ring_size; i++)
+ ring->empty_tx_reqs[i] = i;
} else {
ena_qid = ENA_IO_RXQ_IDX(ring->id);
ctx.direction = ENA_COM_IO_QUEUE_DIRECTION_RX;
ctx.queue_size = adapter->rx_ring_size;
+ for (i = 0; i < ring->ring_size; i++)
+ ring->empty_rx_reqs[i] = i;
}
ctx.qid = ena_qid;
ctx.msix_vector = -1; /* interrupts not used */
@@ -1152,6 +1157,8 @@ static void ena_free_io_queues_all(struct ena_adapter *adapter)
for (i = 0; i < nb_txq; ++i) {
ena_qid = ENA_IO_TXQ_IDX(i);
ena_com_destroy_io_queue(ena_dev, ena_qid);
+
+ ena_tx_queue_release_bufs(&adapter->tx_ring[i]);
}
for (i = 0; i < nb_rxq; ++i) {
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ena: cleaning HW IO rings configuration
2018-11-14 9:59 [dpdk-dev] [PATCH] net/ena: cleaning HW IO rings configuration Rafal Kozik
@ 2018-11-16 10:56 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-11-16 10:56 UTC (permalink / raw)
To: Rafal Kozik, dev; +Cc: mw, mk, gtzalik, evgenys, matua, igorch
On 11/14/2018 9:59 AM, Rafal Kozik wrote:
> When queues are stoped release tx buffers.
> During start initialize array of empty
> tx/rx reqs with default values.
>
> Fixes: df238f84c0a2 ("net/ena: recreate HW IO rings on start and stop")
>
> Signed-off-by: Rafal Kozik <rk@semihalf.com>
> Acked-by: Michal Krawczyk <mk@semihalf.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-16 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-14 9:59 [dpdk-dev] [PATCH] net/ena: cleaning HW IO rings configuration Rafal Kozik
2018-11-16 10:56 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).