From: Slava Ovsiienko <viacheslavo@mellanox.com> To: Shahaf Shuler <shahafs@mellanox.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Viacheslav Ovsiienko <Viacheslav Ovsiienko viacheslavo@mellanox.com>, Mordechay Haimovsky <motih@mellanox.com> Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow query routine in Direct Verbs Date: Wed, 14 Nov 2018 13:47:19 +0000 Message-ID: <1542203224-11936-1-git-send-email-viacheslavo@mellanox.com> (raw) From: Viacheslav Ovsiienko <Viacheslav Ovsiienko viacheslavo@mellanox.com> The flow_dv_query() just returns -ENOTSUP value and does not set provided error parameter structure, that crashes the port_flow_query(). The patch fixes flow_db_query(), now it sets an error parameter structure. Fixes: 684dafe795d0 ("net/mlx5: add flow query abstraction interface") Cc: Moti Haimovsky <motih@mellanox.com> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com> --- drivers/net/mlx5/mlx5_flow_dv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index a2edd16..9991cad 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -2275,8 +2275,10 @@ void *data __rte_unused, struct rte_flow_error *error __rte_unused) { - rte_errno = ENOTSUP; - return -rte_errno; + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, + "flow query with DV is not supported"); } -- 1.8.3.1
next reply other threads:[~2018-11-14 13:47 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-14 13:47 Slava Ovsiienko [this message] 2018-11-15 8:49 ` Shahaf Shuler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1542203224-11936-1-git-send-email-viacheslavo@mellanox.com \ --to=viacheslavo@mellanox.com \ --cc=dev@dpdk.org \ --cc=motih@mellanox.com \ --cc=shahafs@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git