From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00078.outbound.protection.outlook.com [40.107.0.78]) by dpdk.org (Postfix) with ESMTP id CA132683E for ; Wed, 14 Nov 2018 14:47:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qXGLMax96xYcsi697W1BvvRP5l+FWLyuYfmY3hlWTQM=; b=mGqLuq70wj3ANcdc/Z/TwrUcEa1K1VP2nbknhh6d/6uvQ1pZFjpjd51gPyCj+sW+iNxjd9fqvSkX/fdwdfgQyn7ie+mzXa+wu30IXKh/zZjTQrZfJb5Z22ToxG7zVj7cE6IEIJDdNMXWBnhNSAZvqnR1PZodFYDj382eX/2hHd0= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.186.150) by AM4PR05MB1683.eurprd05.prod.outlook.com (10.165.245.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.27; Wed, 14 Nov 2018 13:47:19 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::544b:a68d:e6a5:ba6e]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::544b:a68d:e6a5:ba6e%2]) with mapi id 15.20.1294.045; Wed, 14 Nov 2018 13:47:19 +0000 From: Slava Ovsiienko To: Shahaf Shuler CC: "dev@dpdk.org" , Viacheslav Ovsiienko , Mordechay Haimovsky Thread-Topic: [PATCH] net/mlx5: fix flow query routine in Direct Verbs Thread-Index: AQHUfCCPUIupLtoQlUi8Cx5UeW/nmg== Date: Wed, 14 Nov 2018 13:47:19 +0000 Message-ID: <1542203224-11936-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: CWLP265CA0294.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:5d::18) To AM4PR05MB3265.eurprd05.prod.outlook.com (2603:10a6:205:4::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB1683; 6:vOlYYh4COiP24u3YqhmoSd804k87Egn3/hu+R2QGOQ9aBW59QjdZ61Uv1MZmoJSYwTbNHmctFGTubXfr5JqJhOnaTOLpEhATpZsORIjA+dBoyXKxZsI0efOOF/IIktH3yHAEGC9ZAjIuGUJ/4pnTMNuL99mQKbsjs9ztNwOVB4HnH0W90jroqdAJgBGTVh/G7cZQVq3lQ+7H4JJJA7V3+NlnKHIrFTf0HpBBCZcgi33sUe3fXzTtGKlizy55uMtsuy/U+jGw/NS+/UKzzGI/SynJP4ze9lidTMjHVd8yEPdVbTDyYQYB3I+f59AItNhetHAcpCqNwclRtYrGLsqHtc6SlsF76yc895zzxzpg5pQV7V+GefU3n/eTny9tMj3ee7PY9SVnrvEmEdzXRGFrSyWbcZCzEzQxAq/59dupEKFRnkRLx2aPGaVm/g6R3MViisu4xUW4V1xIEp92UQxo1Q==; 5:ATAVsz7/xUW/b93XXOqhVB3bfPVLolPtG2TAH/QpLCawUeV/kgvl9KMqTmY8SpWOSQsapnTL18DFxHff1fzE2CJvRxChner+IY6EhM5BB48qnrziyX5wRvgRRanh8LazCDLvJehaiNbLUQl1FWvApMorK06k6NBR3QzoOopkJzM=; 7:vPBTKov1KRz0uL+dcUZGLqaHECxwzGS3zqXKywRa4LEqbYkFqOurKxIJSSR11d5fQpo9e8635spQjL4ayqLyVoiMFx368Us/CY20zfOcvLb4JH2UL8BcqVUlHF9+Ig1E674qAxzVfuI26Nwx8CoZGw== x-ms-office365-filtering-correlation-id: 13a12705-ab26-47c7-bc31-08d64a37b1b4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB1683; x-ms-traffictypediagnostic: AM4PR05MB1683: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231410)(944501410)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:AM4PR05MB1683; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB1683; x-forefront-prvs: 085634EFF4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(39860400002)(346002)(366004)(136003)(199004)(189003)(14454004)(7736002)(8676002)(52116002)(256004)(97736004)(386003)(6506007)(6486002)(305945005)(81166006)(6862004)(8936002)(105586002)(37006003)(99286004)(86362001)(316002)(3846002)(6116002)(68736007)(66066001)(25786009)(4326008)(486006)(54906003)(6636002)(2900100001)(6512007)(186003)(102836004)(2906002)(53936002)(36756003)(1857600001)(106356001)(6436002)(81156014)(71200400001)(71190400001)(26005)(107886003)(478600001)(476003)(2616005)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB1683; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: OfZV8gX9XW43zrJEwvvb8Dhj1L+kesKtV8O5WPH+LwoiDU3whEgw6niVV5OdDcCZ8USPh/KW8NKU9cKOCyTJHw2e0rdXgGBnzPBgZXSfAewxk8g8DNFrqTyhZBdjeKHlJ2yndYMDZ6klZkf++PdgvLTHZeDRfdVO19odz+hlUE2WBSsUjV9NZMg4gX/yE86FKmhnZ1VIYUzlkrDXJbpq0xpXRiHgFXUTQPKSDbeVw+ljybEb7gaVmfzLLiN7pFbN5kmk6LixbRi8A+zx7LXn87qvwr75E5xO8El/J2Ur/4E46OwsXDFqJqE9yrgN8u3LXDR2zrzrkb6qqTNJ/+xX1Fudsp3nlRJrJwe8fpZqu1Y= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13a12705-ab26-47c7-bc31-08d64a37b1b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2018 13:47:19.0816 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB1683 Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow query routine in Direct Verbs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 13:47:21 -0000 From: Viacheslav Ovsiienko The flow_dv_query() just returns -ENOTSUP value and does not set provided error parameter structure, that crashes the port_flow_query(). The patch fixes flow_db_query(), now it sets an error parameter structure. Fixes: 684dafe795d0 ("net/mlx5: add flow query abstraction interface") Cc: Moti Haimovsky Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_d= v.c index a2edd16..9991cad 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -2275,8 +2275,10 @@ void *data __rte_unused, struct rte_flow_error *error __rte_unused) { - rte_errno =3D ENOTSUP; - return -rte_errno; + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, + "flow query with DV is not supported"); } =20 =20 --=20 1.8.3.1