* [dpdk-dev] [PATCH] common/cpt: fix bad shift operation
@ 2018-11-15 5:10 Anoob Joseph
2018-11-18 16:36 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Anoob Joseph @ 2018-11-15 5:10 UTC (permalink / raw)
To: Akhil Goyal, Pablo de Lara
Cc: Dwivedi, Ankur, Jacob, Jerin, Athreya, Narayana Prasad, dev,
Joseph, Anoob
From: Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>
Coverity Issue: 323477
Using the rte_bsf32 function to find last set bit. This avoids
the for loop and hence the bad bit shift operation.
Fixes: 351fbee21986 ("common/cpt: support hash")
Signed-off-by: Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>
Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
---
drivers/common/cpt/cpt_ucode.h | 37 ++++++++++++++++---------------------
1 file changed, 16 insertions(+), 21 deletions(-)
diff --git a/drivers/common/cpt/cpt_ucode.h b/drivers/common/cpt/cpt_ucode.h
index c5a9f34..5933ea7 100644
--- a/drivers/common/cpt/cpt_ucode.h
+++ b/drivers/common/cpt/cpt_ucode.h
@@ -3449,32 +3449,27 @@ find_kasumif9_direction_and_length(uint8_t *src,
uint8_t *addr_direction)
{
uint8_t found = 0;
+ uint32_t pos;
+ uint8_t last_byte;
while (!found && counter_num_bytes > 0) {
counter_num_bytes--;
if (src[counter_num_bytes] == 0x00)
continue;
- if (src[counter_num_bytes] == 0x80) {
- *addr_direction = src[counter_num_bytes - 1] & 0x1;
- *addr_length_in_bits = counter_num_bytes * 8 - 1;
- found = 1;
- } else {
- int i = 0;
- uint8_t last_byte = src[counter_num_bytes];
- for (i = 0; i < 8 && found == 0; i++) {
- if (last_byte & (1 << i)) {
- *addr_direction = (last_byte >> (i+1))
- & 0x1;
- if (i != 6)
- *addr_length_in_bits =
- counter_num_bytes * 8
- + (8 - (i + 2));
- else
- *addr_length_in_bits =
- counter_num_bytes * 8;
- found = 1;
- }
- }
+ pos = rte_bsf32(src[counter_num_bytes]);
+ if (pos == 7) {
+ if (likely(counter_num_bytes > 0)) {
+ last_byte = src[counter_num_bytes - 1];
+ *addr_direction = last_byte & 0x1;
+ *addr_length_in_bits = counter_num_bytes * 8
+ - 1;
}
+ } else {
+ last_byte = src[counter_num_bytes];
+ *addr_direction = (last_byte >> (pos + 1)) & 0x1;
+ *addr_length_in_bits = counter_num_bytes * 8
+ + (8 - (pos + 2));
+ }
+ found = 1;
}
}
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] common/cpt: fix bad shift operation
2018-11-15 5:10 [dpdk-dev] [PATCH] common/cpt: fix bad shift operation Anoob Joseph
@ 2018-11-18 16:36 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-11-18 16:36 UTC (permalink / raw)
To: Anoob Joseph, Dwivedi, Ankur
Cc: dev, Akhil Goyal, Pablo de Lara, Jacob, Jerin, Athreya,
Narayana Prasad, Joseph, Anoob
15/11/2018 06:10, Anoob Joseph:
> From: Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>
>
> Coverity Issue: 323477
>
> Using the rte_bsf32 function to find last set bit. This avoids
> the for loop and hence the bad bit shift operation.
>
> Fixes: 351fbee21986 ("common/cpt: support hash")
>
> Signed-off-by: Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>
> Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-18 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 5:10 [dpdk-dev] [PATCH] common/cpt: fix bad shift operation Anoob Joseph
2018-11-18 16:36 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).