DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/bonding: check return value in bond_ethdev_configure
@ 2018-11-16 14:54 Lee Daly
  2018-11-16 15:43 ` Ferruh Yigit
  2018-11-16 16:48 ` [dpdk-dev] [PATCH v2] net/bonding: fix possible silent failure in configuration Lee Daly
  0 siblings, 2 replies; 4+ messages in thread
From: Lee Daly @ 2018-11-16 14:54 UTC (permalink / raw)
  To: declan.doherty, chas3; +Cc: dev, Lee Daly

This patch checks the return value of function
rte_eth_bond_8023ad_agg_selection_set() in bond_ethdev_configure
for error return value.

Signed-off-by: Lee Daly <lee.daly@intel.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 156f31c..a7612ae 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3420,9 +3420,14 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
 				     "Failed to parse agg selection mode for bonded device %s",
 				     name);
 		}
-		if (internals->mode == BONDING_MODE_8023AD)
-			rte_eth_bond_8023ad_agg_selection_set(port_id,
-							      agg_mode);
+		if (internals->mode == BONDING_MODE_8023AD) {
+			if (rte_eth_bond_8023ad_agg_selection_set(port_id,
+							      agg_mode) < 0) {
+				RTE_BOND_LOG(ERR, "Invalid args for agg selection"
+					     " set for bonded device %s", name);
+				return -1;
+			}
+		}
 	}
 
 	/* Parse/add slave ports to bonded device */
-- 
2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-16 17:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-16 14:54 [dpdk-dev] [PATCH] net/bonding: check return value in bond_ethdev_configure Lee Daly
2018-11-16 15:43 ` Ferruh Yigit
2018-11-16 16:48 ` [dpdk-dev] [PATCH v2] net/bonding: fix possible silent failure in configuration Lee Daly
2018-11-16 17:37   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).