From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BB52F568A for ; Tue, 27 Nov 2018 12:13:25 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BAC9D4E92A; Tue, 27 Nov 2018 11:13:24 +0000 (UTC) Received: from ovpn-112-67.ams2.redhat.com (ovpn-112-67.ams2.redhat.com [10.36.112.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0225608C2; Tue, 27 Nov 2018 11:13:23 +0000 (UTC) Message-ID: <1543317202.5400.13.camel@redhat.com> From: Mohammed Gamal To: Ferruh Yigit , dev@dpdk.org Date: Tue, 27 Nov 2018 12:13:22 +0100 In-Reply-To: <26d50d0f-8eb0-608f-9aed-5f3b39a85ff8@intel.com> References: <1543265151-14617-1-git-send-email-mgamal@redhat.com> <26d50d0f-8eb0-608f-9aed-5f3b39a85ff8@intel.com> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 27 Nov 2018 11:13:24 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] kni: Fix build on RHEL 8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: mgamal@redhat.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 11:13:26 -0000 On Tue, 2018-11-27 at 10:55 +0000, Ferruh Yigit wrote: > On 11/26/2018 8:45 PM, Mohammed Gamal wrote: > > As RHEL8 beta has been released and is based on recent upstream > > kernels > > which don't use ndo_change_mtu_rh74 function. Fix the build so that > > it > > doesn't fail because the function is missing > > > > Signed-off-by: Mohammed Gamal > > --- > >  kernel/linux/kni/compat.h | 3 ++- > >  1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h > > index 5aadebb..bc81d0c 100644 > > --- a/kernel/linux/kni/compat.h > > +++ b/kernel/linux/kni/compat.h > > @@ -103,7 +103,8 @@ > >  #endif > >   > >  #if (defined(RHEL_RELEASE_CODE) && \ > > - (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5))) > > + (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \ > > + (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0))) > >  #define ndo_change_mtu ndo_change_mtu_rh74 > > What RHEL use, can you please confirm it turns back to > `ndo_change_mtu`, instead > of something like `ndo_change_mtu_rh8x`? There are no such functions in the RHEL8 kernel. You may check the kernel source code from the SRPM available here: http://ftp.redhat.com/redhat/rhel/rhel-8-beta/baseos/source/Packages/ke rnel-4.18.0-32.el8.src.rpm > > >  #endif > >   > > > >