* [dpdk-dev] [PATCH] mk: don't install meson.build in usertools
@ 2018-11-27 19:35 Timothy Redaelli
2018-11-28 10:13 ` Luca Boccassi
0 siblings, 1 reply; 3+ messages in thread
From: Timothy Redaelli @ 2018-11-27 19:35 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Bruce Richardson, dev
In commit 7dd34c71de2a ("usertools: install with meson") meson.build was
added in usertools directory and so it's copied to $(datadir)/usertools
with "make install".
This patch avoids to copy meson.build when installing usertools with
"make install".
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
mk/rte.sdkinstall.mk | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
index 8296e6dbd..2d34b4e5a 100644
--- a/mk/rte.sdkinstall.mk
+++ b/mk/rte.sdkinstall.mk
@@ -99,8 +99,9 @@ install-runtime:
--exclude 'app/cmdline*' --exclude app/test \
--exclude app/testacl --exclude app/testpipeline app | \
tar -xf - -C $(DESTDIR)$(bindir) $(TAR_X_FLAGS)
- $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir))
- $(Q)cp $(CP_FLAGS) $(RTE_SDK)/usertools $(DESTDIR)$(datadir)
+ $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir)/usertools)
+ $(Q)tar -cf - -C $(RTE_SDK) --exclude meson.build usertools | \
+ tar -xf - -C $(DESTDIR)$(datadir)/usertools $(TAR_X_FLAGS)
$(Q)$(call rte_mkdir, $(DESTDIR)$(sbindir))
$(Q)$(call rte_symlink, $(DESTDIR)$(datadir)/usertools/dpdk-devbind.py, \
$(DESTDIR)$(sbindir)/dpdk-devbind)
--
2.19.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: don't install meson.build in usertools
2018-11-27 19:35 [dpdk-dev] [PATCH] mk: don't install meson.build in usertools Timothy Redaelli
@ 2018-11-28 10:13 ` Luca Boccassi
2018-12-19 0:00 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Luca Boccassi @ 2018-11-28 10:13 UTC (permalink / raw)
To: Timothy Redaelli, Thomas Monjalon; +Cc: Bruce Richardson, dev
On Tue, 2018-11-27 at 20:35 +0100, Timothy Redaelli wrote:
> In commit 7dd34c71de2a ("usertools: install with meson") meson.build
> was
> added in usertools directory and so it's copied to
> $(datadir)/usertools
> with "make install".
>
> This patch avoids to copy meson.build when installing usertools with
> "make install".
>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> mk/rte.sdkinstall.mk | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
> index 8296e6dbd..2d34b4e5a 100644
> --- a/mk/rte.sdkinstall.mk
> +++ b/mk/rte.sdkinstall.mk
> @@ -99,8 +99,9 @@ install-runtime:
> --exclude 'app/cmdline*' --exclude app/test \
> --exclude app/testacl --exclude app/testpipeline app
> | \
> tar -xf - -C $(DESTDIR)$(bindir) $(TAR_X_FLAGS)
> - $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir))
> - $(Q)cp $(CP_FLAGS) $(RTE_SDK)/usertools $(DESTDIR)$(datadir)
> + $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir)/usertools)
> + $(Q)tar -cf - -C $(RTE_SDK) --exclude meson.build
> usertools | \
> + tar -xf - -C $(DESTDIR)$(datadir)/usertools
> $(TAR_X_FLAGS)
> $(Q)$(call rte_mkdir, $(DESTDIR)$(sbindir))
> $(Q)$(call
> rte_symlink, $(DESTDIR)$(datadir)/usertools/dpdk-devbind.py, \
> $(DESTDIR)$(sbindir)/dpdk-
> devbind)
Acked-by: Luca Boccassi <bluca@debian.org>
Should probably add:
Fixes: 7dd34c71de2a ("usertools: install with meson")
Cc: stable@dpdk.org
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: don't install meson.build in usertools
2018-11-28 10:13 ` Luca Boccassi
@ 2018-12-19 0:00 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-12-19 0:00 UTC (permalink / raw)
To: Timothy Redaelli; +Cc: dev, Luca Boccassi, Bruce Richardson
28/11/2018 11:13, Luca Boccassi:
> On Tue, 2018-11-27 at 20:35 +0100, Timothy Redaelli wrote:
> > In commit 7dd34c71de2a ("usertools: install with meson") meson.build
> > was
> > added in usertools directory and so it's copied to
> > $(datadir)/usertools
> > with "make install".
> >
> > This patch avoids to copy meson.build when installing usertools with
> > "make install".
> >
> > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> Acked-by: Luca Boccassi <bluca@debian.org>
>
> Should probably add:
>
> Fixes: 7dd34c71de2a ("usertools: install with meson")
> Cc: stable@dpdk.org
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-19 0:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-27 19:35 [dpdk-dev] [PATCH] mk: don't install meson.build in usertools Timothy Redaelli
2018-11-28 10:13 ` Luca Boccassi
2018-12-19 0:00 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).