From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com
 [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id C474E1B433
 for <dev@dpdk.org>; Wed, 28 Nov 2018 11:13:26 +0100 (CET)
Received: by mail-wm1-f66.google.com with SMTP id a18so1298457wmj.1
 for <dev@dpdk.org>; Wed, 28 Nov 2018 02:13:26 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:content-transfer-encoding:mime-version;
 bh=gHmgZ4TUVet6VmuJ5BZOW2ocwh2Wd3Cz5kMd17/g4mM=;
 b=lU5qdX+QKmF2UWo2j5U1GWQZ4eyWKEoM0wWEDZDD1x4FgZbHc93AyQm8YcWfXPoo/X
 SjVd4+Lo5gEpIYTT6T1U4yq5ieUHVkKYLN9MTjlO1AuaOOkPji+dXvCTDRSBqiSYRLVh
 82LDGhdAiIoJpYqWgFllH95CgwUqHWfuzWgE21OSVH/jY0htI0sCd0IGZwGtXSAd1SK7
 TMv/fUxh/c3C3q8j1VH2K0mPP/HGjBZTcwMZyT96kHBD+57L39p40Yc2NOaCEQX4TyLo
 njeXA2zMxeRespvB6bCDFoc+luogVdL3lPTR7l2mAeuBxH5GmzkCohAAkkkEAM4K0hDp
 QZ8w==
X-Gm-Message-State: AA+aEWZv/iD1LJ9i6CNFbhTviz+sz/Xb6T0WZj1Ija4kS5yDTGC17hlx
 5CNlbBfxNzObQI3wnDi4TLU=
X-Google-Smtp-Source: AFSGD/UXeXDgW0Wa/sM15LOkIZ1zzShv9YNZ9TGNA2TxIjMiKj96bnFpeIXOCb6Wf06Xpx4j8DHnPw==
X-Received: by 2002:a1c:da0c:: with SMTP id r12mr2087543wmg.54.1543400006380; 
 Wed, 28 Nov 2018 02:13:26 -0800 (PST)
Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556])
 by smtp.gmail.com with ESMTPSA id v1sm6343544wrw.90.2018.11.28.02.13.25
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 28 Nov 2018 02:13:25 -0800 (PST)
Message-ID: <1543400004.5087.13.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Timothy Redaelli <tredaelli@redhat.com>, Thomas Monjalon
 <thomas@monjalon.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Date: Wed, 28 Nov 2018 10:13:24 +0000
In-Reply-To: <f4aeee269d9d83e8e65ea6acd62933da6b31102d.1543347246.git.tredaelli@redhat.com>
References: <f4aeee269d9d83e8e65ea6acd62933da6b31102d.1543347246.git.tredaelli@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] mk: don't install meson.build in usertools
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2018 10:13:26 -0000

On Tue, 2018-11-27 at 20:35 +0100, Timothy Redaelli wrote:
> In commit 7dd34c71de2a ("usertools: install with meson") meson.build
> was
> added in usertools directory and so it's copied to
> $(datadir)/usertools
> with "make install".
>=20
> This patch avoids to copy meson.build when installing usertools with
> "make install".
>=20
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> =C2=A0mk/rte.sdkinstall.mk | 5 +++--
> =C2=A01 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
> index 8296e6dbd..2d34b4e5a 100644
> --- a/mk/rte.sdkinstall.mk
> +++ b/mk/rte.sdkinstall.mk
> @@ -99,8 +99,9 @@ install-runtime:
> =C2=A0		--exclude 'app/cmdline*' --exclude app/test \
> =C2=A0		--exclude app/testacl --exclude app/testpipeline app
> | \
> =C2=A0	=C2=A0=C2=A0=C2=A0=C2=A0tar -xf -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0-C $(DESTDIR)$(bindir) $(TAR_X_FLAGS)
> -	$(Q)$(call rte_mkdir,=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(DESTDIR)$(da=
tadir))
> -	$(Q)cp $(CP_FLAGS) $(RTE_SDK)/usertools $(DESTDIR)$(datadir)
> +	$(Q)$(call rte_mkdir,=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(DESTDIR)$(da=
tadir)/usertools)
> +	$(Q)tar -cf -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-C $(RTE_SDK) --exclud=
e meson.build
> usertools | \
> +	=C2=A0=C2=A0=C2=A0=C2=A0tar -xf -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-C=
 $(DESTDIR)$(datadir)/usertools
> $(TAR_X_FLAGS)
> =C2=A0	$(Q)$(call rte_mkdir,=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(DESTDIR=
)$(sbindir))
> =C2=A0	$(Q)$(call
> rte_symlink,=C2=A0=C2=A0=C2=A0=C2=A0$(DESTDIR)$(datadir)/usertools/dpdk-d=
evbind.py, \
> =C2=A0	=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0$(DESTDIR)$(sbindir)/dpdk-
> devbind)

Acked-by: Luca Boccassi <bluca@debian.org>

Should probably add:

Fixes: 7dd34c71de2a ("usertools: install with meson")
Cc: stable@dpdk.org

--=20
Kind regards,
Luca Boccassi