From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com
 [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id B009C1D9E
 for <dev@dpdk.org>; Wed, 28 Nov 2018 11:15:05 +0100 (CET)
Received: by mail-wr1-f65.google.com with SMTP id t3so25671058wrr.3
 for <dev@dpdk.org>; Wed, 28 Nov 2018 02:15:05 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:content-transfer-encoding:mime-version;
 bh=WzKbs5WYclLWM6tfqz30mpf+Aq0GecO7Sts2DPpVMQk=;
 b=hmeXYwcK2DjSeBDXwNKPsnI+MauxRvrjkEB7aB+fQblalmTiLVMi2adcWWjTn/rEbV
 lJ3c7h48e/vGmKdcss/tOiObslALvqYPfDURbt7nfaeBAK3ZFmltFgiAsIhsVya+ROOX
 kqGl27JR+31iV3ax6dZUXYajS+aha+D4ovavJAOnfwhCKDkYyZiZVWHqiauP9/m025xX
 HYx57guw5lL+F0lIWDIBgxo7i9/NbCrEKxBlwu11m3tB6lxD7cHJxL+JFGNtrt3u8eyj
 /6TfI1E1tQAAZ8/Ot1SkRVRQllyKEklc4LNmB3drs3KzktfokovbzJkhl3cH/cZzN4iB
 KTfg==
X-Gm-Message-State: AA+aEWYMfWy1tHDatcovB/0jgW/yk+8dOt5d+8DJbcfUow02WYatFiBO
 ZKRgGKZLo0w4em9b6S7+ShE=
X-Google-Smtp-Source: AFSGD/ViD1Dw8iJImYErkGVCZRj4pLcGSLKg+IuYA80aqnGQbT8BBUVdbwC1MlSb0j4AHAdLh/gFqg==
X-Received: by 2002:adf:9083:: with SMTP id i3mr2029817wri.124.1543400105277; 
 Wed, 28 Nov 2018 02:15:05 -0800 (PST)
Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556])
 by smtp.gmail.com with ESMTPSA id t9sm7179954wrr.17.2018.11.28.02.15.04
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 28 Nov 2018 02:15:04 -0800 (PST)
Message-ID: <1543400103.5087.14.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Cc: konstantin.ananyev@intel.com, Chas Williams <chas3@att.com>
Date: Wed, 28 Nov 2018 10:15:03 +0000
In-Reply-To: <20181127045613.16437-1-3chas3@gmail.com>
References: <20181127045613.16437-1-3chas3@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] ip_frag: fix ipv6 when MTU sizes not aligned
 to 8 bytes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2018 10:15:05 -0000

On Mon, 2018-11-26 at 23:56 -0500, Chas Williams wrote:
> From: Chas Williams <chas3@att.com>
>=20
> The same issue was fixed on for the ipv4 version of this routine in
> commit 8d4d3a4f7337 ("ip_frag: handle MTU sizes not aligned to 8
> bytes").
> Briefly, the size of an ipv6 header is always 40 bytes.=C2=A0=C2=A0With a=
n MTU
> of
> 1500, this will never produce a multiple of 8 bytes for the frag_size
> and this routine can never succeed. Since RTE_ASSERTS are disabled by
> default, this failure is tpyically ignored.
>=20
> To fix this, round down to the nearest 8 bytes and use this when
> producing the fragments.
>=20
> Fixes: 0aa31d7a5929 ("ip_frag: add IPv6 fragmentation support")
>=20
> Signed-off-by: Chas Williams <chas3@att.com>
> ---
> =C2=A0lib/librte_ip_frag/rte_ip_frag.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A01 +
> =C2=A0lib/librte_ip_frag/rte_ipv6_fragmentation.c | 18 +++++++++++-------
> =C2=A02 files changed, 12 insertions(+), 7 deletions(-)

Acked-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi