DPDK patches and discussions
 help / color / mirror / Atom feed
From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
To: jerin.jacob@caviumnetworks.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3] app/eventdev: detect deadlock for timer event producer
Date: Mon,  3 Dec 2018 11:48:14 -0600	[thread overview]
Message-ID: <1543859294-24259-1-git-send-email-erik.g.carrillo@intel.com> (raw)
In-Reply-To: <1525469883-8342-1-git-send-email-erik.g.carrillo@intel.com>

If timer events get dropped for some reason, the thread that launched
producer and worker cores will never exit, because the deadlock check
doesn't currently apply to the event timer adapter case. This commit
fixes this.

Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a
producer")

Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
v3:
 - Forgot to add Jerin's ack line.
v2:
 - Add a fixline to commit message (Jerin)

 app/test-eventdev/test_perf_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
index 8618775..f99a6a6 100644
--- a/app/test-eventdev/test_perf_common.c
+++ b/app/test-eventdev/test_perf_common.c
@@ -327,7 +327,8 @@ perf_launch_lcores(struct evt_test *test, struct evt_options *opt,
 		}
 
 		if (new_cycles - dead_lock_cycles > dead_lock_sample &&
-				opt->prod_type == EVT_PROD_TYPE_SYNT) {
+		    (opt->prod_type == EVT_PROD_TYPE_SYNT ||
+		     opt->prod_type == EVT_PROD_TYPE_EVENT_TIMER_ADPTR)) {
 			remaining = t->outstand_pkts - processed_pkts(t);
 			if (dead_lock_remaining == remaining) {
 				rte_event_dev_dump(opt->dev_id, stdout);
-- 
2.6.4

  parent reply	other threads:[~2018-12-03 17:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 21:38 [dpdk-dev] [PATCH v1 1/1] test: fix build with GCC 4.8.5 Erik Gabriel Carrillo
2018-05-05  3:17 ` Jerin Jacob
2018-05-05  4:55 ` Stephen Hemminger
2018-05-07 18:15   ` Carrillo, Erik G
2018-05-07 19:12 ` [dpdk-dev] [PATCH v2 " Erik Gabriel Carrillo
2018-05-09  9:07   ` Jerin Jacob
2018-12-03 16:21 ` [dpdk-dev] [PATCH v2] app/eventdev: detect deadlock for timer event producer Erik Gabriel Carrillo
2018-12-03 17:48 ` Erik Gabriel Carrillo [this message]
2018-12-16 16:59   ` [dpdk-dev] [PATCH v3] " Jerin Jacob Kollanukkaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1543859294-24259-1-git-send-email-erik.g.carrillo@intel.com \
    --to=erik.g.carrillo@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).