From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, nhorman@tuxdriver.com, tredaelli@redhat.com,
ferruh.yigit@intel.com, ivan.malov@oktetlabs.ru,
arybchenko@solarflare.com
Subject: [dpdk-dev] [PATCH] log: add missing experimental tag
Date: Tue, 4 Dec 2018 09:28:31 +0100 [thread overview]
Message-ID: <1543912111-8106-1-git-send-email-david.marchand@redhat.com> (raw)
When rte_log_register_type_and_pick_level() has been introduced, it has
been correctly added to the EXPERIMENTAL section of the eal map and the
symbol itself has been marked at its definition.
However, the declaration of this symbol in rte_log.h is missing the
__rte_experimental tag.
Because of this, a user can try to call this symbol without being aware
this is an experimental api (neither compilation nor link warning).
Fixes: b22e77c02620 ("eal: register log type and pick level from args")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_eal/common/include/rte_log.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h
index 2f789cb..f334efc 100644
--- a/lib/librte_eal/common/include/rte_log.h
+++ b/lib/librte_eal/common/include/rte_log.h
@@ -24,6 +24,7 @@
#include <rte_common.h>
#include <rte_config.h>
+#include <rte_compat.h>
struct rte_log_dynamic_type;
@@ -226,6 +227,7 @@ struct rte_logs {
* - >=0: the newly registered log type
* - <0: rte_log_register() error value
*/
+__rte_experimental
int rte_log_register_type_and_pick_level(const char *name, uint32_t level_def);
/**
--
1.8.3.1
next reply other threads:[~2018-12-04 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 8:28 David Marchand [this message]
2018-12-04 15:18 ` Neil Horman
2018-12-18 10:29 ` David Marchand
2018-12-19 1:30 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543912111-8106-1-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=nhorman@tuxdriver.com \
--cc=stable@dpdk.org \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).