From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, "Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Konstantin Ananyev" <konstantin.ananyev@huawei.com>,
"Reshma Pattan" <reshma.pattan@intel.com>
Subject: Re: [PATCH v8 2/7] latencystats: do not use floating point
Date: Thu, 12 Jun 2025 00:18:24 +0200 [thread overview]
Message-ID: <15450130.EVyyLHbfrO@thomas> (raw)
In-Reply-To: <20250610141355.91759-3-stephen@networkplumber.org>
10/06/2025 16:12, Stephen Hemminger:
> The cycle counts do not need to be stored as floating point.
> Instead keep track of latency in cycles, and convert to
> nanoseconds when read.
>
> Use scaled math with exponential Weighted Moving Average weight
> of .25 to avoid use of floating point for that.
>
> The average latency took too long to "warm up".
> Do what RFC 6298 suggests and initialize on first sample.
An error appears when compiling patch by patch on Arm:
error: implicit declaration of function 'llabs'
glob_stats->jitter += llabs(delta)
note: include '<stdlib.h>' or provide a declaration of 'llabs'
I can fix it while merging.
next prev parent reply other threads:[~2025-06-11 22:18 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 19:50 [RFC] latencystats: performance overhaul Stephen Hemminger
2024-04-08 21:26 ` [PATCH v2] " Stephen Hemminger
2024-04-19 17:28 ` [PATCH v4 0/6] latencystats: cleanup Stephen Hemminger
2024-04-19 17:28 ` [PATCH v4 1/6] latencystats: replace use of VLA Stephen Hemminger
2024-04-19 17:28 ` [PATCH v4 2/6] latencystats: handle fractional cycles per ns Stephen Hemminger
2024-04-19 17:28 ` [PATCH v4 3/6] latencystats: do not use floating point Stephen Hemminger
2024-04-19 18:49 ` Morten Brørup
2024-04-19 22:45 ` Stephen Hemminger
2024-04-20 7:31 ` Morten Brørup
2024-04-19 17:28 ` [PATCH v4 4/6] latencystats: fix log messages Stephen Hemminger
2024-04-19 17:28 ` [PATCH v4 5/6] latencystats: update include files Stephen Hemminger
2024-04-19 17:28 ` [PATCH v4 6/6] latencystats: fix for pedantic warnings Stephen Hemminger
2024-04-22 15:21 ` [PATCH v5 0/9] latencystats: improve algorithms and tests Stephen Hemminger
2024-04-22 15:21 ` [PATCH v5 1/9] latencystats: replace use of VLA Stephen Hemminger
2024-04-22 15:21 ` [PATCH v5 2/9] latencystats: handle fractional cycles per ns Stephen Hemminger
2024-04-22 15:21 ` [PATCH v5 3/9] latencystats: do not use floating point Stephen Hemminger
2024-04-22 15:21 ` [PATCH v5 4/9] latencystats: fix log messages Stephen Hemminger
2024-04-22 15:21 ` [PATCH v5 5/9] latencystats: update include files Stephen Hemminger
2024-04-22 15:21 ` [PATCH v5 6/9] latencystats: enforce that unused callback function is NULL Stephen Hemminger
2024-04-22 15:21 ` [PATCH v5 7/9] latencystats: add metric for number of samples Stephen Hemminger
2024-04-22 15:21 ` [PATCH v5 8/9] test: use initialization in latencystats test Stephen Hemminger
2024-04-22 15:21 ` [PATCH v5 9/9] test: add more latencystats tests Stephen Hemminger
2024-05-29 22:54 ` [PATCH v6 0/8] latencystats: improvements to algorithm and test Stephen Hemminger
2024-05-29 22:54 ` [PATCH v6 1/8] latencystats: replace use of VLA Stephen Hemminger
2024-05-29 22:54 ` [PATCH v6 2/8] latencystats: handle fractional cycles per ns Stephen Hemminger
2024-05-29 22:54 ` [PATCH v6 3/8] latencystats: do not use floating point Stephen Hemminger
2024-05-29 22:54 ` [PATCH v6 4/8] latencystats: fix log messages Stephen Hemminger
2024-05-29 22:54 ` [PATCH v6 5/8] latencystats: update include files Stephen Hemminger
2024-05-29 22:54 ` [PATCH v6 6/8] latencystats: enforce that unused callback function is NULL Stephen Hemminger
2024-05-29 22:54 ` [PATCH v6 7/8] latencystats: add metric for number of samples Stephen Hemminger
2024-05-29 22:54 ` [PATCH v6 8/8] test: update to latencystats tests Stephen Hemminger
2024-07-04 15:21 ` [PATCH v6 0/8] latencystats: improvements to algorithm and test David Marchand
2025-02-13 21:20 ` [PATCH v7 0/7] latencystats: cleanup Stephen Hemminger
2025-02-13 21:20 ` [PATCH v7 1/7] latencystats: handle fractional cycles per ns Stephen Hemminger
2025-02-13 21:20 ` [PATCH v7 2/7] latencystats: do not use floating point Stephen Hemminger
2025-02-14 8:52 ` Konstantin Ananyev
2025-02-13 21:20 ` [PATCH v7 3/7] latencystats: fix log messages Stephen Hemminger
2025-02-13 21:20 ` [PATCH v7 4/7] latencystats: update include files Stephen Hemminger
2025-02-13 21:20 ` [PATCH v7 5/7] latencystats: enforce that unused callback function is NULL Stephen Hemminger
2025-02-13 21:20 ` [PATCH v7 6/7] latencystats: add metric for number of samples Stephen Hemminger
2025-02-13 21:20 ` [PATCH v7 7/7] test: update to latencystats tests Stephen Hemminger
2025-02-14 9:36 ` [PATCH v7 0/7] latencystats: cleanup Bruce Richardson
2025-06-10 10:01 ` Thomas Monjalon
2025-06-10 14:12 ` [PATCH v8 0/7] latencystats: cleanup and floating point fixes Stephen Hemminger
2025-06-10 14:12 ` [PATCH v8 1/7] latencystats: handle fractional cycles per ns Stephen Hemminger
2025-06-10 14:12 ` [PATCH v8 2/7] latencystats: do not use floating point Stephen Hemminger
2025-06-11 22:18 ` Thomas Monjalon [this message]
2025-06-10 14:12 ` [PATCH v8 3/7] latencystats: fix log messages Stephen Hemminger
2025-06-10 14:12 ` [PATCH v8 4/7] latencystats: update include files Stephen Hemminger
2025-06-10 14:12 ` [PATCH v8 5/7] latencystats: enforce that unused callback function is NULL Stephen Hemminger
2025-06-10 14:12 ` [PATCH v8 6/7] latencystats: add metric for number of samples Stephen Hemminger
2025-06-10 14:12 ` [PATCH v8 7/7] test: update to latencystats tests Stephen Hemminger
2025-06-12 7:00 ` David Marchand
2025-06-12 15:47 ` Stephen Hemminger
2025-06-11 22:48 ` [PATCH v8 0/7] latencystats: cleanup and floating point fixes Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15450130.EVyyLHbfrO@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=reshma.pattan@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).