From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id D854A1B925 for ; Mon, 17 Dec 2018 20:02:44 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id p6so37453wmc.1 for ; Mon, 17 Dec 2018 11:02:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=GUo6MlDI/J4Yh5K9dQZgI7o/5zy8mUBEkOGWx3yvEC8=; b=CV0lUwvaCIPCHBeKuAlkMjZ3HXUlHteL84Y7mMG2yVy4vysmfKo04KzrOy5x7ISsOu KQeOnssNKhLarZR+/TyqAjW6ykmwUmRf4j/d3fRHhM2eoVeadpxtrKwSfXKS6j7b48+V Rpb4WU/O9ydt8HYpYRdR6sWSUs64vwzDjnuOF5lEmgJB0B3xWPQN+ncBSLi7DrTYpzL1 LHbrjyKH362ldLvk56v9kG1mDHy2UVepXgI75LLuqnQLV0mPx4cHcMiKi5LIYCZs+8v0 WFUQ7E70LfZsMvif6l77s+PNrVAaepivgj81FtLNk9dsfL31nvH+oRdKZEEt4p3EP8A0 iAOg== X-Gm-Message-State: AA+aEWYufanY69xxL+9ZFzb6rkBpFc/t5vVjB9614Cyiki75Jh8rKqfM VKSUXlh+SbTt/vbIXC6aIvo= X-Google-Smtp-Source: AFSGD/Ua0QJI/dmZIUB3W5szWeLLXjmw9ZhcYJdxp8j4Of+G7vLHB9idfyuc0zNRIEmexJRhzKy9Qg== X-Received: by 2002:a1c:b70b:: with SMTP id h11mr322375wmf.72.1545073364338; Mon, 17 Dec 2018 11:02:44 -0800 (PST) Received: from localhost ([82.113.183.179]) by smtp.gmail.com with ESMTPSA id x8sm45138wmd.45.2018.12.17.11.02.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Dec 2018 11:02:43 -0800 (PST) Message-ID: <1545073352.7111.23.camel@debian.org> From: Luca Boccassi To: "Wiles, Keith" Cc: "dev@dpdk.org" Date: Mon, 17 Dec 2018 20:02:32 +0100 In-Reply-To: References: <20181216174604.91445-1-keith.wiles@intel.com> <1544998977.4766.10.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 19:02:45 -0000 On Mon, 2018-12-17 at 16:26 +0000, Wiles, Keith wrote: > > On Dec 16, 2018, at 4:22 PM, Luca Boccassi > > wrote: > >=20 > > On Sun, 2018-12-16 at 11:46 -0600, Keith Wiles wrote: > > > --- /dev/null > > > +++ b/lib/librte_dfs/meson.build > > > @@ -0,0 +1,47 @@ > > > +# SPDX-License-Identifier: BSD-3-Clause > > > +# Copyright(c) 2018 Intel Corporation > > > + > > > +version =3D 1 > >=20 > > You can leave the version out if it's 1, it's the default >=20 > I understand that maybe the default, but it should not hurt anything > and then the developer can update it as needed, right? Yes it does not hurt, I don't mind much either way, just wanted to mention there's a default in case you prefer to reduce duplication. > > > --- /dev/null > > > +++ b/lib/librte_dfs/Makefile > > > @@ -0,0 +1,51 @@ > > > +# SPDX-License-Identifier: BSD-3-Clause > > > +# Copyright(c) 2018 Intel Corporation > > > + > > > +include $(RTE_SDK)/mk/rte.vars.mk > > > + > > > +# library name > > > +LIB =3D librte_dfs.a > > > + > > > +CFLAGS +=3D $(WERROR_FLAGS) -I$(SRCDIR) -O3 > > > +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API -D_FILE_OFFSET_BITS=3D64 > > > +CFLAGS +=3D -D_GNU_SOURCE > > > +CFLAGS +=3D -I$(RTE_SDK)/drivers/bus/pci > > > +LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_hash -lrte_ethdev > > > -lrte_utils > > > +LDLIBS +=3D -lrte_ring -lrte_timer -lrte_rawdev -lrte_cryptodev > > > +LDLIBS +=3D -lpthread > > > +LDLIBS +=3D $(shell pkg-config --libs-only-l fuse3) > > > +LDLIBS +=3D $(shell pkg-config --libs-only-l jansson) > >=20 > > Why --libs-only-l ? If the libraries are not installed in the > > canonical > > path (eg: build-root-without-chroot) it will break as it won't use > > the > > -L >=20 > OK, will look at this one and see if I had a reason to use libs-only- > l. >=20 > >=20 > > --=C2=A0 > > Kind regards, > > Luca Boccassi >=20 > Regards, > Keith >=20 --=20 Kind regards, Luca Boccassi