DPDK patches and discussions
 help / color / mirror / Atom feed
From: Arnon Warshavsky <arnon@qwilt.com>
To: ferruh.yigit@intel.com, ajit.khaparde@broadcom.com, thomasm@mellanox.com
Cc: dev@dpdk.org, arnon@qwilt.com
Subject: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk
Date: Tue, 18 Dec 2018 17:19:00 +0200	[thread overview]
Message-ID: <1545146340-17973-1-git-send-email-arnon@qwilt.com> (raw)
In-Reply-To: <1545141782-31841-1-git-send-email-arnon@qwilt.com>

Bugzilla ID: 165
Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>

Explicitly collect the error code of the
multiple awk script calls
---
 devtools/checkpatches.sh | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index ee8debe..3b03b7e 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -44,6 +44,8 @@ print_usage () {
 }
 
 check_forbidden_additions() { # <patch>
+	res=0
+
 	# refrain from new additions of rte_panic() and rte_exit()
 	# multiple folders and expressions are separated by spaces
 	awk -v FOLDERS="lib drivers" \
@@ -51,7 +53,8 @@ check_forbidden_additions() { # <patch>
 		-v RET_ON_FAIL=1 \
 		-v MESSAGE='Using rte_panic/rte_exit' \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-		"$1"
+		"$1" || res=1
+
 	# svg figures must be included with wildcard extension
 	# because of png conversion for pdf docs
 	awk -v FOLDERS='doc' \
@@ -59,7 +62,9 @@ check_forbidden_additions() { # <patch>
 		-v RET_ON_FAIL=1 \
 		-v MESSAGE='Using explicit .svg extension instead of .*' \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-		"$1"
+		"$1" || res = 1
+
+	return $res
 }
 
 number=0
-- 
1.8.3.1

  parent reply	other threads:[~2018-12-18 15:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 14:03 [dpdk-dev] [PATCH v1] " Arnon Warshavsky
2018-12-18 14:12 ` David Marchand
2018-12-18 14:16   ` David Marchand
2018-12-18 14:27     ` David Marchand
2018-12-18 14:35       ` Thomas Monjalon
2018-12-18 14:44         ` Arnon Warshavsky
2018-12-18 14:48           ` Thomas Monjalon
2018-12-18 14:49           ` David Marchand
2018-12-18 14:53             ` Arnon Warshavsky
2018-12-18 14:55               ` David Marchand
2018-12-18 15:19 ` Arnon Warshavsky [this message]
2018-12-21  0:59   ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2019-01-17 12:20     ` David Marchand
2019-01-17 15:32       ` Thomas Monjalon
2019-01-17 17:25         ` David Marchand
2019-01-17 21:34           ` Ajit Khaparde
2019-01-17 21:47             ` Thomas Monjalon
2019-01-18  4:59               ` Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1545146340-17973-1-git-send-email-arnon@qwilt.com \
    --to=arnon@qwilt.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomasm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).