[dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

[dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

[Arnon Warshavsky]

Bugzilla ID: 165
Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>

Explicitly collect the output and result of the
multiple awk script calls, print and return error
if any of them fails
---
 devtools/checkpatches.sh | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index ee8debe..df4336c 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -44,22 +44,35 @@ print_usage () {
 }
 
 check_forbidden_additions() { # <patch>
+	res=0
+
 	# refrain from new additions of rte_panic() and rte_exit()
 	# multiple folders and expressions are separated by spaces
-	awk -v FOLDERS="lib drivers" \
+	result=$(awk -v FOLDERS="lib drivers" \
 		-v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
 		-v RET_ON_FAIL=1 \
 		-v MESSAGE='Using rte_panic/rte_exit' \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-		"$1"
+		"$1")
+	if [ $? -ne 0 ] ; then
+		echo $result
+		res=1
+	fi
+
 	# svg figures must be included with wildcard extension
 	# because of png conversion for pdf docs
-	awk -v FOLDERS='doc' \
+	result=$(awk -v FOLDERS='doc' \
 		-v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
 		-v RET_ON_FAIL=1 \
 		-v MESSAGE='Using explicit .svg extension instead of .*' \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-		"$1"
+		"$1")
+        if [ $? -ne 0 ] ; then
+                echo $result
+                res=1
+        fi
+
+	return $res
 }
 
 number=0
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

[David Marchand]

On Tue, Dec 18, 2018 at 3:03 PM Arnon Warshavsky <arnon@qwilt.com> wrote:

> Bugzilla ID: 165
> Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
>
> Explicitly collect the output and result of the
> multiple awk script calls, print and return error
> if any of them fails
> ---
>  devtools/checkpatches.sh | 21 +++++++++++++++++----
>  1 file changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index ee8debe..df4336c 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -44,22 +44,35 @@ print_usage () {
>  }
>
>  check_forbidden_additions() { # <patch>
> +       res=0
> +
>         # refrain from new additions of rte_panic() and rte_exit()
>         # multiple folders and expressions are separated by spaces
> -       awk -v FOLDERS="lib drivers" \
> +       result=$(awk -v FOLDERS="lib drivers" \
>                 -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
>                 -v RET_ON_FAIL=1 \
>                 -v MESSAGE='Using rte_panic/rte_exit' \
>                 -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk
> \
> -               "$1"
> +               "$1")
> +       if [ $? -ne 0 ] ; then
> +               echo $result
> +               res=1
> +       fi
> +
>         # svg figures must be included with wildcard extension
>         # because of png conversion for pdf docs
> -       awk -v FOLDERS='doc' \
> +       result=$(awk -v FOLDERS='doc' \
>                 -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
>                 -v RET_ON_FAIL=1 \
>                 -v MESSAGE='Using explicit .svg extension instead of .*' \
>                 -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk
> \
> -               "$1"
> +               "$1")
> +        if [ $? -ne 0 ] ; then
> +                echo $result
> +                res=1
> +        fi
> +
> +       return $res
>  }
>
>  number=0
> --
> 1.8.3.1
>

How about just this change ?

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index ee8debe..8385384 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -51,7 +51,7 @@ check_forbidden_additions() { # <patch>
                -v RET_ON_FAIL=1 \
                -v MESSAGE='Using rte_panic/rte_exit' \
                -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-               "$1"
+               "$1" &&
        # svg figures must be included with wildcard extension
        # because of png conversion for pdf docs
        awk -v FOLDERS='doc' \

-- 
David Marchand

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

[David Marchand]

On Tue, Dec 18, 2018 at 3:12 PM David Marchand <david.marchand@redhat.com>
wrote:

>
>
> On Tue, Dec 18, 2018 at 3:03 PM Arnon Warshavsky <arnon@qwilt.com> wrote:
>
>> Bugzilla ID: 165
>> Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
>> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
>>
>> Explicitly collect the output and result of the
>> multiple awk script calls, print and return error
>> if any of them fails
>> ---
>>  devtools/checkpatches.sh | 21 +++++++++++++++++----
>>  1 file changed, 17 insertions(+), 4 deletions(-)
>>
>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
>> index ee8debe..df4336c 100755
>> --- a/devtools/checkpatches.sh
>> +++ b/devtools/checkpatches.sh
>> @@ -44,22 +44,35 @@ print_usage () {
>>  }
>>
>>  check_forbidden_additions() { # <patch>
>> +       res=0
>> +
>>         # refrain from new additions of rte_panic() and rte_exit()
>>         # multiple folders and expressions are separated by spaces
>> -       awk -v FOLDERS="lib drivers" \
>> +       result=$(awk -v FOLDERS="lib drivers" \
>>                 -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
>>                 -v RET_ON_FAIL=1 \
>>                 -v MESSAGE='Using rte_panic/rte_exit' \
>>                 -f $(dirname $(readlink -e
>> $0))/check-forbidden-tokens.awk \
>> -               "$1"
>> +               "$1")
>> +       if [ $? -ne 0 ] ; then
>> +               echo $result
>> +               res=1
>> +       fi
>> +
>>         # svg figures must be included with wildcard extension
>>         # because of png conversion for pdf docs
>> -       awk -v FOLDERS='doc' \
>> +       result=$(awk -v FOLDERS='doc' \
>>                 -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
>>                 -v RET_ON_FAIL=1 \
>>                 -v MESSAGE='Using explicit .svg extension instead of .*' \
>>                 -f $(dirname $(readlink -e
>> $0))/check-forbidden-tokens.awk \
>> -               "$1"
>> +               "$1")
>> +        if [ $? -ne 0 ] ; then
>> +                echo $result
>> +                res=1
>> +        fi
>> +
>> +       return $res
>>  }
>>
>>  number=0
>> --
>> 1.8.3.1
>>
>
> How about just this change ?
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index ee8debe..8385384 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -51,7 +51,7 @@ check_forbidden_additions() { # <patch>
>                 -v RET_ON_FAIL=1 \
>                 -v MESSAGE='Using rte_panic/rte_exit' \
>                 -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk
> \
> -               "$1"
> +               "$1" &&
>         # svg figures must be included with wildcard extension
>         # because of png conversion for pdf docs
>         awk -v FOLDERS='doc' \
>

Ah ok, nevermind, two issues.

-- 
David Marchand

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

[David Marchand]

On Tue, Dec 18, 2018 at 3:16 PM David Marchand <david.marchand@redhat.com>
wrote:

>
>
> On Tue, Dec 18, 2018 at 3:12 PM David Marchand <david.marchand@redhat.com>
> wrote:
>
>>
>>
>> On Tue, Dec 18, 2018 at 3:03 PM Arnon Warshavsky <arnon@qwilt.com> wrote:
>>
>>> Bugzilla ID: 165
>>> Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
>>> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
>>>
>>> Explicitly collect the output and result of the
>>> multiple awk script calls, print and return error
>>> if any of them fails
>>> ---
>>>  devtools/checkpatches.sh | 21 +++++++++++++++++----
>>>  1 file changed, 17 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
>>> index ee8debe..df4336c 100755
>>> --- a/devtools/checkpatches.sh
>>> +++ b/devtools/checkpatches.sh
>>> @@ -44,22 +44,35 @@ print_usage () {
>>>  }
>>>
>>>  check_forbidden_additions() { # <patch>
>>> +       res=0
>>> +
>>>         # refrain from new additions of rte_panic() and rte_exit()
>>>         # multiple folders and expressions are separated by spaces
>>> -       awk -v FOLDERS="lib drivers" \
>>> +       result=$(awk -v FOLDERS="lib drivers" \
>>>                 -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
>>>                 -v RET_ON_FAIL=1 \
>>>                 -v MESSAGE='Using rte_panic/rte_exit' \
>>>                 -f $(dirname $(readlink -e
>>> $0))/check-forbidden-tokens.awk \
>>> -               "$1"
>>> +               "$1")
>>> +       if [ $? -ne 0 ] ; then
>>> +               echo $result
>>> +               res=1
>>> +       fi
>>> +
>>>         # svg figures must be included with wildcard extension
>>>         # because of png conversion for pdf docs
>>> -       awk -v FOLDERS='doc' \
>>> +       result=$(awk -v FOLDERS='doc' \
>>>                 -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
>>>                 -v RET_ON_FAIL=1 \
>>>                 -v MESSAGE='Using explicit .svg extension instead of .*'
>>> \
>>>                 -f $(dirname $(readlink -e
>>> $0))/check-forbidden-tokens.awk \
>>> -               "$1"
>>> +               "$1")
>>> +        if [ $? -ne 0 ] ; then
>>> +                echo $result
>>> +                res=1
>>> +        fi
>>> +
>>> +       return $res
>>>  }
>>>
>>>  number=0
>>> --
>>> 1.8.3.1
>>>
>>
>> How about just this change ?
>>
>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
>> index ee8debe..8385384 100755
>> --- a/devtools/checkpatches.sh
>> +++ b/devtools/checkpatches.sh
>> @@ -51,7 +51,7 @@ check_forbidden_additions() { # <patch>
>>                 -v RET_ON_FAIL=1 \
>>                 -v MESSAGE='Using rte_panic/rte_exit' \
>>                 -f $(dirname $(readlink -e
>> $0))/check-forbidden-tokens.awk \
>> -               "$1"
>> +               "$1" &&
>>         # svg figures must be included with wildcard extension
>>         # because of png conversion for pdf docs
>>         awk -v FOLDERS='doc' \
>>
>
> Ah ok, nevermind, two issues.
>

Ok, second attempt, and this time tested :-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index ee8debe..915ef67 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -51,7 +51,7 @@ check_forbidden_additions() { # <patch>
                -v RET_ON_FAIL=1 \
                -v MESSAGE='Using rte_panic/rte_exit' \
                -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-               "$1"
+               "$1" && \
        # svg figures must be included with wildcard extension
        # because of png conversion for pdf docs
        awk -v FOLDERS='doc' \


-- 
David Marchand

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

[Thomas Monjalon]

18/12/2018 15:27, David Marchand:
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -51,7 +51,7 @@ check_forbidden_additions() { # <patch>
>                 -v RET_ON_FAIL=1 \
>                 -v MESSAGE='Using rte_panic/rte_exit' \
>                 -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
> -               "$1"
> +               "$1" && \
>         # svg figures must be included with wildcard extension
>         # because of png conversion for pdf docs
>         awk -v FOLDERS='doc' \

+1

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

[Arnon Warshavsky]

The reason I did not use the && approach is that if both checks have errors,
only the first will be reported and we want all errors to be reported at
once
without discovering them one by one after every fix.

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

[Thomas Monjalon]

18/12/2018 15:44, Arnon Warshavsky:
> The reason I did not use the && approach is that if both checks have errors,
> only the first will be reported and we want all errors to be reported at
> once
> without discovering them one by one after every fix.

So please do a simple OR of $?
No need to capture the output.

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

[David Marchand]

On Tue, Dec 18, 2018 at 3:45 PM Arnon Warshavsky <arnon@qwilt.com> wrote:

> The reason I did not use the && approach is that if both checks have
> errors,
> only the first will be reported and we want all errors to be reported at
> once
> without discovering them one by one after every fix.
>
>
Ok, then:

 diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index ee8debe..7457f01 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -46,12 +46,13 @@ print_usage () {
 check_forbidden_additions() { # <patch>
        # refrain from new additions of rte_panic() and rte_exit()
        # multiple folders and expressions are separated by spaces
+       ret=0
        awk -v FOLDERS="lib drivers" \
                -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
                -v RET_ON_FAIL=1 \
                -v MESSAGE='Using rte_panic/rte_exit' \
                -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-               "$1"
+               "$1" || ret=1
        # svg figures must be included with wildcard extension
        # because of png conversion for pdf docs
        awk -v FOLDERS='doc' \
@@ -59,7 +60,9 @@ check_forbidden_additions() { # <patch>
                -v RET_ON_FAIL=1 \
                -v MESSAGE='Using explicit .svg extension instead of .*' \
                -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-               "$1"
+               "$1" || ret=1
+
+       return $ret
 }

 number=0


No need for all those checks on $? and the output saving.


-- 
David Marchand

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

[Arnon Warshavsky]

>
> No need for all those checks on $? and the output saving.
>

You blew my cover guys. I am not a shell scripts person :)
You are right. WIll change that

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

[David Marchand]

On Tue, Dec 18, 2018 at 3:54 PM Arnon Warshavsky <arnon@qwilt.com> wrote:

> No need for all those checks on $? and the output saving.
>>
>
> You blew my cover guys. I am not a shell scripts person :)
> You are right. WIll change that
>

Eheh, I am looking at shell scripts at the same time... hence the quick
replies ;-)


-- 
David Marchand

[dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

[Arnon Warshavsky]

Bugzilla ID: 165
Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>

Explicitly collect the error code of the
multiple awk script calls
---
 devtools/checkpatches.sh | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index ee8debe..3b03b7e 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -44,6 +44,8 @@ print_usage () {
 }
 
 check_forbidden_additions() { # <patch>
+	res=0
+
 	# refrain from new additions of rte_panic() and rte_exit()
 	# multiple folders and expressions are separated by spaces
 	awk -v FOLDERS="lib drivers" \
@@ -51,7 +53,8 @@ check_forbidden_additions() { # <patch>
 		-v RET_ON_FAIL=1 \
 		-v MESSAGE='Using rte_panic/rte_exit' \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-		"$1"
+		"$1" || res=1
+
 	# svg figures must be included with wildcard extension
 	# because of png conversion for pdf docs
 	awk -v FOLDERS='doc' \
@@ -59,7 +62,9 @@ check_forbidden_additions() { # <patch>
 		-v RET_ON_FAIL=1 \
 		-v MESSAGE='Using explicit .svg extension instead of .*' \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-		"$1"
+		"$1" || res = 1
+
+	return $res
 }
 
 number=0
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

[Thomas Monjalon]

18/12/2018 16:19, Arnon Warshavsky:
> Bugzilla ID: 165
> Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
> 
> Explicitly collect the error code of the
> multiple awk script calls

Applied, thanks

Note: the explanation must be moved at the beginning of the message.

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

[David Marchand]

On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> 18/12/2018 16:19, Arnon Warshavsky:
> > Bugzilla ID: 165
>

Thomas,

I just noticed that the bz is still opened.
Who is supposed to close bug reports ?


-- 
David Marchand

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

[Thomas Monjalon]

17/01/2019 13:20, David Marchand:
> On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > 18/12/2018 16:19, Arnon Warshavsky:
> > > Bugzilla ID: 165
> >
> 
> Thomas,
> 
> I just noticed that the bz is still opened.
> Who is supposed to close bug reports ?

I think we never formally described this workflow.

I suggest to expect the bug reporter to close the bug.

Comments?
Should we update the website with this info?

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

[David Marchand]

On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> 17/01/2019 13:20, David Marchand:
> > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon <thomas@monjalon.net>
> wrote:
> >
> > > 18/12/2018 16:19, Arnon Warshavsky:
> > > > Bugzilla ID: 165
> > >
> >
> > Thomas,
> >
> > I just noticed that the bz is still opened.
> > Who is supposed to close bug reports ?
>
> I think we never formally described this workflow.
>
> I suggest to expect the bug reporter to close the bug.
>

Well, the reporter is most likely able to reproduce an issue and confirm it
is fixed.
So +1 for me.


-- 
David Marchand

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

[Ajit Khaparde]

On Thu, Jan 17, 2019 at 9:26 AM David Marchand <david.marchand@redhat.com>
wrote:

> On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon <thomas@monjalon.net>
> wrote:
>
>> 17/01/2019 13:20, David Marchand:
>> > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon <thomas@monjalon.net>
>> wrote:
>> >
>> > > 18/12/2018 16:19, Arnon Warshavsky:
>> > > > Bugzilla ID: 165
>> > >
>> >
>> > Thomas,
>> >
>> > I just noticed that the bz is still opened.
>> > Who is supposed to close bug reports ?
>>
>> I think we never formally described this workflow.
>>
>> I suggest to expect the bug reporter to close the bug.
>>
>
> Well, the reporter is most likely able to reproduce an issue and confirm
> it is fixed.
> So +1 for me.
>
Unless I miss an update, I generally try to assign the BZ back to the
reporter to get an agreement,
or confirmation as needed and get the BZ closed.
So +1 for me as well.

Thanks
Ajit

>
>
> --
> David Marchand
>

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

[Thomas Monjalon]

17/01/2019 22:34, Ajit Khaparde:
> On Thu, Jan 17, 2019 at 9:26 AM David Marchand <david.marchand@redhat.com>
> wrote:
> 
> > On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon <thomas@monjalon.net>
> > wrote:
> >
> >> 17/01/2019 13:20, David Marchand:
> >> > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon <thomas@monjalon.net>
> >> wrote:
> >> >
> >> > > 18/12/2018 16:19, Arnon Warshavsky:
> >> > > > Bugzilla ID: 165
> >> > >
> >> >
> >> > Thomas,
> >> >
> >> > I just noticed that the bz is still opened.
> >> > Who is supposed to close bug reports ?
> >>
> >> I think we never formally described this workflow.
> >>
> >> I suggest to expect the bug reporter to close the bug.
> >>
> >
> > Well, the reporter is most likely able to reproduce an issue and confirm
> > it is fixed.
> > So +1 for me.
> >
> Unless I miss an update, I generally try to assign the BZ back to the
> reporter to get an agreement,
> or confirmation as needed and get the BZ closed.
> So +1 for me as well.

Interesting. Ajit, I think we never documented this process.
Would you like to describe it briefly here:
	http://core.dpdk.org/contribute/#bugzilla

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

[Ajit Khaparde]

On Thu, Jan 17, 2019 at 1:47 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> 17/01/2019 22:34, Ajit Khaparde:
> > On Thu, Jan 17, 2019 at 9:26 AM David Marchand <
> david.marchand@redhat.com>
> > wrote:
> >
> > > On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon <thomas@monjalon.net>
> > > wrote:
> > >
> > >> 17/01/2019 13:20, David Marchand:
> > >> > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon <
> thomas@monjalon.net>
> > >> wrote:
> > >> >
> > >> > > 18/12/2018 16:19, Arnon Warshavsky:
> > >> > > > Bugzilla ID: 165
> > >> > >
> > >> >
> > >> > Thomas,
> > >> >
> > >> > I just noticed that the bz is still opened.
> > >> > Who is supposed to close bug reports ?
> > >>
> > >> I think we never formally described this workflow.
> > >>
> > >> I suggest to expect the bug reporter to close the bug.
> > >>
> > >
> > > Well, the reporter is most likely able to reproduce an issue and
> confirm
> > > it is fixed.
> > > So +1 for me.
> > >
> > Unless I miss an update, I generally try to assign the BZ back to the
> > reporter to get an agreement,
> > or confirmation as needed and get the BZ closed.
> > So +1 for me as well.
>
> Interesting. Ajit, I think we never documented this process.
> Would you like to describe it briefly here:
>         http://core.dpdk.org/contribute/#bugzilla
>
> Sure. I am working on it. But I think we need to also mention that
bugs will also be aged out if there is no activity on it for say "1" year?
Unless there is a valid reason to keep it open?