From: Konstantin Ananyev <konstantin.ananyev@intel.com>
To: dev@dpdk.org
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: [dpdk-dev] [PATCH v2 1/2] rwlock: introduce 'try' semantics for RD and WR locking
Date: Wed, 19 Dec 2018 18:07:16 +0000 [thread overview]
Message-ID: <1545242837-28585-2-git-send-email-konstantin.ananyev@intel.com> (raw)
In-Reply-To: <1542130061-3702-1-git-send-email-konstantin.ananyev@intel.com>
Introduce rte_rwlock_read_trylock() and rte_rwlock_write_trylock().
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.nagarahalli@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
.../common/include/generic/rte_rwlock.h | 56 +++++++++++++++++++
1 file changed, 56 insertions(+)
diff --git a/lib/librte_eal/common/include/generic/rte_rwlock.h b/lib/librte_eal/common/include/generic/rte_rwlock.h
index 5751a0e6d..b05d85aee 100644
--- a/lib/librte_eal/common/include/generic/rte_rwlock.h
+++ b/lib/librte_eal/common/include/generic/rte_rwlock.h
@@ -75,6 +75,36 @@ rte_rwlock_read_lock(rte_rwlock_t *rwl)
}
}
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice.
+ *
+ * try to take a read lock.
+ *
+ * @param rwl
+ * A pointer to a rwlock structure.
+ * @return
+ * - zero if the lock is successfully taken
+ * - -EBUSY if lock could not be acquired for reading because a
+ * writer holds the lock
+ */
+static inline __rte_experimental int
+rte_rwlock_read_trylock(rte_rwlock_t *rwl)
+{
+ int32_t x;
+ int success = 0;
+
+ while (success == 0) {
+ x = rwl->cnt;
+ /* write lock is held */
+ if (x < 0)
+ return -EBUSY;
+ success = rte_atomic32_cmpset((volatile uint32_t *)&rwl->cnt,
+ (uint32_t)x, (uint32_t)(x + 1));
+ }
+ return 0;
+}
+
/**
* Release a read lock.
*
@@ -87,6 +117,32 @@ rte_rwlock_read_unlock(rte_rwlock_t *rwl)
rte_atomic32_dec((rte_atomic32_t *)(intptr_t)&rwl->cnt);
}
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice.
+ *
+ * try to take a write lock.
+ *
+ * @param rwl
+ * A pointer to a rwlock structure.
+ * @return
+ * - zero if the lock is successfully taken
+ * - -EBUSY if lock could not be acquired for writing because
+ * it was already locked for reading or writing
+ */
+static inline __rte_experimental int
+rte_rwlock_write_trylock(rte_rwlock_t *rwl)
+{
+ int32_t x;
+
+ x = rwl->cnt;
+ if (x != 0 || rte_atomic32_cmpset((volatile uint32_t *)&rwl->cnt,
+ 0, (uint32_t)-1) == 0)
+ return -EBUSY;
+
+ return 0;
+}
+
/**
* Take a write lock. Loop until the lock is held.
*
--
2.17.1
next prev parent reply other threads:[~2018-12-19 18:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 17:27 [dpdk-dev] [PATCH 0/2] Add " Konstantin Ananyev
2018-11-13 17:27 ` [dpdk-dev] [PATCH 1/2] rwlock: introduce " Konstantin Ananyev
2018-12-19 6:37 ` Honnappa Nagarahalli
2018-12-19 8:30 ` Gavin Hu (Arm Technology China)
2018-12-19 10:28 ` Mattias Rönnblom
2018-12-19 10:56 ` Ananyev, Konstantin
2018-12-19 11:00 ` Bruce Richardson
2018-12-19 12:41 ` Ananyev, Konstantin
2018-12-19 15:11 ` Honnappa Nagarahalli
2018-12-19 16:27 ` Ananyev, Konstantin
2018-11-13 17:27 ` [dpdk-dev] [PATCH 2/2] test: add new test-cases for rwlock autotest Konstantin Ananyev
2018-12-19 8:28 ` Gavin Hu (Arm Technology China)
2018-12-19 2:39 ` [dpdk-dev] [PATCH 0/2] Add 'try' semantics for RD and WR locking Thomas Monjalon
2018-12-19 18:07 ` [dpdk-dev] [PATCH v2 " Konstantin Ananyev
2018-12-19 19:53 ` Thomas Monjalon
2018-12-19 18:07 ` Konstantin Ananyev [this message]
2018-12-19 18:07 ` [dpdk-dev] [PATCH v2 2/2] test: add new test-cases for rwlock autotest Konstantin Ananyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545242837-28585-2-git-send-email-konstantin.ananyev@intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).