From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 48ADB2C54 for ; Thu, 20 Dec 2018 11:42:25 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id u4so1199596wrp.3 for ; Thu, 20 Dec 2018 02:42:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=1SfDCyND00jl8oCFJr6533XZES9q12qGjncZgaG3+yE=; b=GTljunL/DdDnz6Kt+NLxtGwKje8dBpMjNcNtoLs1iiCFZT3aCMJiI0k5HSxqIa+WS1 aqsxD4PYEYVgcFXYPz74IYxeirb1k+sTQc4wjI0c58AkeVbhDMnWkEvrK+bnQSMxEU1l Dk1nbIhy51N1lrAvD8/lq5F6lMaL4HgDNJWJujkyKloaoOOhGdc6bIe/vB/6bsd0qJwi Ja8uZUrn+01DSmbNXlFF2etWBahfGwZEtjcciFt3+s82J70dWbodYvfA1sJN717vWGAB 1Nt1p2Vqlo1Z7jq2fjHe8/tqcWF6kXmm7OsBaq8bGiD2oVPrd+nc1DxMY/P5cbnvzOub DjYA== X-Gm-Message-State: AA+aEWaVxi8SsHnAr8bTLaezu6e7/6GJm0lZmpsOSvAzTOA5LeOa2UWx 54At9oe+Ll1xB4OFCoRAbyY= X-Google-Smtp-Source: AFSGD/WUcZaBx0XTbjjVLKJRgi7tVoUkQxJ+30GQeh7tVdsn2ecCdLgjz4sOTV9AfptacgwNk0EhTw== X-Received: by 2002:a5d:5351:: with SMTP id t17mr22079533wrv.288.1545302544734; Thu, 20 Dec 2018 02:42:24 -0800 (PST) Received: from localhost ([46.183.103.8]) by smtp.gmail.com with ESMTPSA id f66sm8861949wmd.28.2018.12.20.02.42.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Dec 2018 02:42:23 -0800 (PST) Message-ID: <1545302540.9718.20.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon , "Burakov, Anatoly" Cc: "Hunt, David" , Liang Ma , dev@dpdk.org, qian.q.xu@intel.com, ferruh.yigit@intel.com Date: Thu, 20 Dec 2018 11:42:20 +0100 In-Reply-To: <9037763.qK0Rf51nFT@xps> References: <1544786028-10138-1-git-send-email-liang.j.ma@intel.com> <636b6d77-c9d1-8ae7-7999-11e03bf645c8@intel.com> <9037763.qK0Rf51nFT@xps> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] libs/power: add p-state driver compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 10:42:25 -0000 On Thu, 2018-12-20 at 11:10 +0100, Thomas Monjalon wrote: > 20/12/2018 10:33, Burakov, Anatoly: > > On 20-Dec-18 9:25 AM, Burakov, Anatoly wrote: > > > On 19-Dec-18 8:31 PM, Thomas Monjalon wrote: > > > > 19/12/2018 10:09, Hunt, David: > > > > > On 19/12/2018 3:18 AM, Thomas Monjalon wrote: > > > > > > 14/12/2018 14:11, Liang Ma: > > > > > > > Previously, in order to use the power library, it was > > > > > > > necessary > > > > > > > for the user to disable the intel_pstate driver by adding > > > > > > > =E2=80=9Cintel_pstate=3Ddisable=E2=80=9D to the kernel comman= d line for the > > > > > > > system, > > > > > > > which causes the acpi_cpufreq driver to be loaded in its > > > > > > > place. > > > > > > >=20 > > > > > > > This patch adds the ability for the power library use the > > > > > > > intel-pstate > > > > > > > driver. > > > > > > >=20 > > > > > > > It adds a new suite of functions behind the current power > > > > > > > library API, > > > > > > > and will seamlessly set up the user facing API function > > > > > > > pointers to > > > > > > > the relevant functions depending on whether the system is > > > > > > > running with > > > > > > > acpi_cpufreq kernel driver, intel_pstate kernel driver or > > > > > > > in a guest, > > > > > > > using kvm. The library API and ABI is unchanged. > > > > > > >=20 > > > > > > > Signed-off-by: Liang Ma > > > > > > >=20 > > > > > > > Reviewed-by: Anatoly Burakov > > > > > > > --- > > > > > >=20 > > > > > > Please write a changelog when sending a new version. > > > > > >=20 > > > > > > Dave, any comment on this patch? > > > > >=20 > > > > >=20 > > > > > Looks good to me. > > > > >=20 > > > > > Acked-by: David Hunt > > > > >=20 > > > > >=20 > > > > > > > --- /dev/null > > > > > > > +++ b/lib/librte_power/power_pstate_cpufreq.c > > > > > > > @@ -0,0 +1,770 @@ > > > > > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > > > > + * Copyright(c) 2018-2018 Intel Corporation > > > > > >=20 > > > > > > Something wrong here :) > > > > >=20 > > > > > Yes, should simply be "Copyright(c) 2018 Intel Corporation" > > > >=20 > > > >=20 > > > > There is also a compilation error with meson: > > > >=20 > > > > lib/librte_power/rte_power_empty_poll.h:20:10: fatal error: > > > > =C2=A0=C2=A0=C2=A0=C2=A0rte_timer.h: No such file or directory > > >=20 > > > That's an EAL header, and this file was not modified or > > > referenced in=C2=A0 > > > this commit. This sounds like a pre-existing problem (with meson=C2= =A0 > > > build-system?), not related to the patchset. > > >=20 > > > Is this library not built by default by our patch compilation CI? > > >=20 > >=20 > > Disregard that, the patch has a bug in meson build file. > >=20 > > Still, why doesn't our CI build meson? >=20 > I think we should build a new CI for compilation testing. > Luca proposed to use OBS. > Luca, can we work on it? https://build.opensuse.org/package/show/home:bluca:dpdk/dpdk The Debian/Ubuntu builds use Meson, the Fedora/CentOS/RHEL/SUSE ones use the makefiles. More complexity (eg: building with both on all distros) can be added with a bit of work, if required and if it's worth it. A postreceive curl call can be added to trigger it on every push to master. Emails on failure can be sent with the logs. --=20 Kind regards, Luca Boccassi