From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: olivier.matz@6wind.com, yskoh@mellanox.com,
arybchenko@solarflare.com, bernard.iremonger@intel.com,
David Marchand <david.marchand@6wind.com>
Subject: [dpdk-dev] [PATCH v2 1/3] mbuf: add sanity checks on segment metadata
Date: Mon, 7 Jan 2019 09:57:10 +0100 [thread overview]
Message-ID: <1546851432-19397-2-git-send-email-david.marchand@redhat.com> (raw)
In-Reply-To: <1546851432-19397-1-git-send-email-david.marchand@redhat.com>
From: David Marchand <david.marchand@6wind.com>
Add some basic checks on the segments offset and length metadata:
always funny to have a < 0 tailroom cast to uint16_t ;-).
Signed-off-by: David Marchand <david.marchand@6wind.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
---
lib/librte_mbuf/rte_mbuf.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
index 9790b4f..3bbd3f5 100644
--- a/lib/librte_mbuf/rte_mbuf.c
+++ b/lib/librte_mbuf/rte_mbuf.c
@@ -200,6 +200,10 @@ struct rte_mempool *
pkt_len = m->pkt_len;
do {
+ if (m->data_off > m->buf_len)
+ rte_panic("data offset too big in mbuf segment\n");
+ if (m->data_off + m->data_len > m->buf_len)
+ rte_panic("data length too big in mbuf segment\n");
nb_segs -= 1;
pkt_len -= m->data_len;
} while ((m = m->next) != NULL);
--
1.8.3.1
next prev parent reply other threads:[~2019-01-07 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 8:57 [dpdk-dev] [PATCH v2 0/3] segment sanity checks David Marchand
2019-01-07 8:57 ` David Marchand [this message]
2019-01-07 8:57 ` [dpdk-dev] [PATCH v2 2/3] mbuf: add a non fatal sanity check helper David Marchand
2019-01-07 8:57 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: check mbufs in verbose mode David Marchand
2019-01-08 9:53 ` Iremonger, Bernard
2019-01-15 1:33 ` [dpdk-dev] [PATCH v2 0/3] segment sanity checks Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546851432-19397-2-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).