From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id EA32D235; Mon, 7 Jan 2019 14:45:57 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id z5so434991wrt.11; Mon, 07 Jan 2019 05:45:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=t7BzbHPyBlpu4d/zsYj4uymJFfs9yEMYMjOLrSljQM8=; b=Z6hyzCDxwDaL564BxpWY9li4L0DlYWjk//V6SyedPdBI2nN+HMeUkqOd7KnsbTRV1t IkClHRDJ0hokV1/z/hG2A6sEgq2/DsxHPGcEbixSCabQ5/WhDrDFpEdv90vjUc88WNYV zYUy2c0hYKI8L9Y/S2krB8QWjOzXMJBCwMvMDTXq1fFRW9B0hSKVUAVMm5ozzcVOl7zS pQ83dPj85o8wlwiGdm3CXdsjcASh7q8Zwnf9kJJjQZy8iJTRaIWwabYKfVJPaBclxdJL c9rBN3D0xEmodgKsPXtEeC+impjtFADCYp83S3Tf4MgmI6H0rWKjoH3oIdIM6rktar0x F79w== X-Gm-Message-State: AJcUuke9BRWi1cQFKe4Fd5QMc322wk3JRVGjTAB2766pi9d70OLWdupF Py+9CLSm9ou1VqUkHITD2TY= X-Google-Smtp-Source: ALg8bN4UncSrWa/yxodhHe9fopuW/ZhHK8Q7Heh5lW4G4tyApqSIcwppdXtS6QeOtzYLseoOi54bOA== X-Received: by 2002:adf:9c01:: with SMTP id f1mr53825162wrc.286.1546868757472; Mon, 07 Jan 2019 05:45:57 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id 126sm6468595wmd.1.2019.01.07.05.45.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Jan 2019 05:45:56 -0800 (PST) Message-ID: <1546868756.6022.21.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org, christian.ehrhardt@canonical.com, stable@dpdk.org Date: Mon, 07 Jan 2019 13:45:56 +0000 In-Reply-To: <20190107122401.GA14912@bricha3-MOBL.ger.corp.intel.com> References: <20181224125627.25690-1-bluca@debian.org> <20190107122401.GA14912@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] build: use generic march on arm64 when using 'default' machine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 13:45:58 -0000 On Mon, 2019-01-07 at 12:24 +0000, Bruce Richardson wrote: > On Mon, Dec 24, 2018 at 01:56:27PM +0100, Luca Boccassi wrote: > > When building for generic distribution we need a stable baseline > > architecture, or depending on the build worker the result will > > vary. > >=20 > > Force the default flags if the user explicitly sets > > marchine=3Ddefault >=20 > typo: marchine >=20 > > at configuration time. > >=20 > > Fixes: b1d48c41189a ("build: support ARM with meson") > > Cc: stable@dpdk.org > >=20 > > Signed-off-by: Luca Boccassi > > --- > > =C2=A0config/arm/meson.build | 7 ++++++- > > =C2=A01 file changed, 6 insertions(+), 1 deletion(-) > >=20 > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index dae55d6b2..fa21a2fd2 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > @@ -6,6 +6,7 @@ > > =C2=A0march_opt =3D '-march=3D@0@'.format(machine) > > =C2=A0 > > =C2=A0arm_force_native_march =3D false > > +arm_force_default_march =3D machine =3D=3D 'default' >=20 > Do we need a new variable here? Given it only seems to be used once > below, > I think just having the boolean expression directly in the if > statement is > clearer. If you do keep the variable, suggest putting braces around > the > comparison, otherwise at first glance it looks like a chained > assignment > like you get in C e.g. x =3D y =3D 0; Eheh it looks like I was a bit too hasty - I now remember that the main reason I added a new variable is that the "machine" variable gets overridden just before the if branch, so the original value is lost. I could refactor and rename, but that would be more intrusive so I had opted to just do what was already done for the other "force" case. --=20 Kind regards, Luca Boccassi