From: gavin hu <gavin.hu@arm.com>
To: dev@dpdk.org
Cc: nd@arm.com, thomas@monjalon.net, jerinj@marvell.com,
hemant.agrawal@nxp.com, Honnappa.Nagarahalli@arm.com,
gavin.hu@arm.com, olivier.matz@6wind.com,
bruce.richardson@intel.com, Joyce Kong <joyce.kong@arm.com>
Subject: [dpdk-dev] [PATCH v6 1/3] test/ring: ring perf test case enhancement
Date: Wed, 9 Jan 2019 19:31:40 +0800 [thread overview]
Message-ID: <1547033502-3167-2-git-send-email-gavin.hu@arm.com> (raw)
In-Reply-To: <1547033502-3167-1-git-send-email-gavin.hu@arm.com>
In-Reply-To: <1546483094-29712-2-git-send-email-gavin.hu@arm.com>
From: Joyce Kong <joyce.kong@arm.com>
Run ring perf test on all available cores to really verify MPMC operations.
The old way of running on a pair of cores is not enough for MPMC rings.
Suggested-by: Gavin Hu <gavin.hu@arm.com>
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Ola Liljedahl <ola.liljedahl@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
test/test/test_ring_perf.c | 82 ++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 79 insertions(+), 3 deletions(-)
diff --git a/test/test/test_ring_perf.c b/test/test/test_ring_perf.c
index ebb3939..01c6937 100644
--- a/test/test/test_ring_perf.c
+++ b/test/test/test_ring_perf.c
@@ -9,7 +9,7 @@
#include <rte_cycles.h>
#include <rte_launch.h>
#include <rte_pause.h>
-
+#include <string.h>
#include "test.h"
/*
@@ -20,6 +20,7 @@
* * Empty ring dequeue
* * Enqueue/dequeue of bursts in 1 threads
* * Enqueue/dequeue of bursts in 2 threads
+ * * Enqueue/dequeue of bursts in all available threads
*/
#define RING_NAME "RING_PERF"
@@ -248,9 +249,80 @@ run_on_core_pair(struct lcore_pair *cores, struct rte_ring *r,
}
}
+static rte_atomic32_t synchro;
+static uint64_t queue_count[RTE_MAX_LCORE];
+
+#define TIME_MS 100
+
+static int
+load_loop_fn(void *p)
+{
+ uint64_t time_diff = 0;
+ uint64_t begin = 0;
+ uint64_t hz = rte_get_timer_hz();
+ uint64_t lcount = 0;
+ const unsigned int lcore = rte_lcore_id();
+ struct thread_params *params = p;
+ void *burst[MAX_BURST] = {0};
+
+ /* wait synchro for slaves */
+ if (lcore != rte_get_master_lcore())
+ while (rte_atomic32_read(&synchro) == 0)
+ rte_pause();
+
+ begin = rte_get_timer_cycles();
+ while (time_diff < hz * TIME_MS / 1000) {
+ rte_ring_mp_enqueue_bulk(params->r, burst, params->size, NULL);
+ rte_ring_mc_dequeue_bulk(params->r, burst, params->size, NULL);
+ lcount++;
+ time_diff = rte_get_timer_cycles() - begin;
+ }
+ queue_count[lcore] = lcount;
+ return 0;
+}
+
+static int
+run_on_all_cores(struct rte_ring *r)
+{
+ uint64_t total = 0;
+ unsigned int i, c;
+ struct thread_params param;
+
+ memset(¶m, 0, sizeof(struct thread_params));
+ for (i = 0; i < RTE_DIM(bulk_sizes); i++) {
+ printf("\nBulk enq/dequeue count on size %u\n", bulk_sizes[i]);
+ param.size = bulk_sizes[i];
+ param.r = r;
+
+ /* clear synchro and start slaves */
+ rte_atomic32_set(&synchro, 0);
+ if (rte_eal_mp_remote_launch(load_loop_fn,
+ ¶m, SKIP_MASTER) < 0)
+ return -1;
+
+ /* start synchro and launch test on master */
+ rte_atomic32_set(&synchro, 1);
+ load_loop_fn(¶m);
+
+ rte_eal_mp_wait_lcore();
+
+ RTE_LCORE_FOREACH(c) {
+ printf("Core [%u] count = %"PRIu64"\n",
+ c, queue_count[c]);
+ total += queue_count[c];
+ }
+
+ printf("Total count (size: %u): %"PRIu64"\n", bulk_sizes[i],
+ total);
+ }
+
+ return 0;
+}
+
/*
- * Test function that determines how long an enqueue + dequeue of a single item
- * takes on a single lcore. Result is for comparison with the bulk enq+deq.
+ * Test function that determines how long an enqueue + dequeue of a single
+ * item takes on a single lcore. Result is for comparison with the bulk
+ * enq+deq.
*/
static void
test_single_enqueue_dequeue(struct rte_ring *r)
@@ -394,6 +466,10 @@ test_ring_perf(void)
printf("\n### Testing using two NUMA nodes ###\n");
run_on_core_pair(&cores, r, enqueue_bulk, dequeue_bulk);
}
+
+ printf("\n### Testing using all slave nodes ###\n");
+ run_on_all_cores(r);
+
rte_ring_free(r);
return 0;
}
--
2.7.4
next prev parent reply other threads:[~2019-01-09 11:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 0:55 [dpdk-dev] [PATCH v4 0/3] add rte ring reset api and use it to flush a ring by hash Gavin Hu
2019-01-02 0:55 ` [dpdk-dev] [PATCH v4 1/3] test/ring: ring perf test case enhancement Gavin Hu
2019-01-02 12:49 ` Thomas Monjalon
2019-01-03 2:40 ` Gavin Hu (Arm Technology China)
2019-01-02 0:55 ` [dpdk-dev] [PATCH v4 2/3] ring: add reset api to flush the ring when not in use Gavin Hu
2019-01-02 0:55 ` [dpdk-dev] [PATCH v4 3/3] hash: flush the rings instead of dequeuing one by one Gavin Hu
2019-01-02 12:50 ` [dpdk-dev] [PATCH v4 0/3] add rte ring reset api and use it to flush a ring by hash Thomas Monjalon
2019-01-02 18:40 ` Honnappa Nagarahalli
2019-01-03 2:43 ` Gavin Hu (Arm Technology China)
2019-01-03 2:38 ` [dpdk-dev] [PATCH v5 0/3] ring test enhancement and new ring reset api and use it " gavin hu
2019-01-03 2:38 ` [dpdk-dev] [PATCH v5 1/3] test/ring: ring perf test case enhancement gavin hu
2019-01-03 7:39 ` Thomas Monjalon
2019-01-03 8:22 ` Gavin Hu (Arm Technology China)
2019-01-09 11:31 ` [dpdk-dev] [PATCH v6 0/3] ring test enhancement and new ring reset api and use it by hash gavin hu
2019-01-09 11:31 ` gavin hu [this message]
2019-09-09 5:19 ` [dpdk-dev] [PATCH v7] test/ring: ring perf test case enhancement Joyce Kong
2019-10-08 8:07 ` Olivier Matz
2019-10-24 7:56 ` David Marchand
2019-01-09 11:31 ` [dpdk-dev] [PATCH v6 2/3] ring: add reset API to flush the ring when not in use gavin hu
2019-01-09 11:31 ` [dpdk-dev] [PATCH v6 3/3] hash: flush the rings instead of dequeuing one by one gavin hu
2019-01-09 18:53 ` Wang, Yipeng1
2019-01-03 2:38 ` [dpdk-dev] [PATCH v5 2/3] ring: add reset API to flush the ring when not in use gavin hu
2019-01-03 2:38 ` [dpdk-dev] [PATCH v5 3/3] hash: flush the rings instead of dequeuing one by one gavin hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547033502-3167-2-git-send-email-gavin.hu@arm.com \
--to=gavin.hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=joyce.kong@arm.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).