From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 81EDE1B645; Thu, 10 Jan 2019 14:10:03 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id s12so11334013wrt.4; Thu, 10 Jan 2019 05:10:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=RCratja/vPuqxh9T0lAkiRtuSpEoYUfzl0O99SsmkN0=; b=hkGt3FNoV2rgxqPSeSf+9TsVPDfp4ToA5bOv6KsJD7ST5jkw2lEV0EfEWQ6suJXaRR ITMbAXqBew7VWcfdHn9+HYRvOl7p/1/ulceuSoDkWwzB27HIu/zUvyHHNK3Y/GoSoAMd f1PksugNkKJ+AhUzSRo23FCqyRqGS13eWEghtXymP08WY08fpMp0e17eBSMfaMpx/g9L QEY1DGs2iGV3nxiyX63Le/b043ri+RqEosiw1DT1eK4Rk1vmpIYlrnwJwkrgH5oYHMZd aP8boloTOLwMbsjAAt91UsaS04J80ILCnKQGLXwmOVzXxwpyfoebgcU8MP7r6cc7bFOX xn5A== X-Gm-Message-State: AJcUukckXzaeOU0eGoKNEBNfXWEQhBfaY8K7kk2AcsW+Iyp8wDkA1KID bvzpi35uLUJb6HzLcBuBHlq8lwx+W8g= X-Google-Smtp-Source: ALg8bN6yxyfp5vgNZZDjEwRFNVJPW7YoI7Gd7vLRQMNcz1U4yraSslElMw8Bzj8jKJ9TLqL3VyqMWg== X-Received: by 2002:adf:a28d:: with SMTP id s13mr9678806wra.100.1547125802992; Thu, 10 Jan 2019 05:10:02 -0800 (PST) Received: from localhost ([2001:1be0:110d:fcfe:132c:a71a:1896:1395]) by smtp.gmail.com with ESMTPSA id v133sm16467089wmf.19.2019.01.10.05.10.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 05:10:02 -0800 (PST) Message-ID: <1547125801.16085.2.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Cc: stable@dpdk.org Date: Thu, 10 Jan 2019 13:10:01 +0000 In-Reply-To: <20190110103726.23231-1-bruce.richardson@intel.com> References: <20190110103726.23231-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test-meson-build: fix check for whether meson has run X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 13:10:04 -0000 On Thu, 2019-01-10 at 10:37 +0000, Bruce Richardson wrote: > The current check to see whether we need to call meson or just ninja > simply checked if the build directory existed. However, if meson was > run > but failed, the build directory would still exist. We can fix this by > instead checking for the build.ninja file inside the directory. Once > that > is present, we can use ninja safely and let it worry about rerunning > meson if necessary. >=20 > Fixes: a55277a788df ("devtools: add test script for meson builds") > CC: stable@dpdk.org >=20 > Signed-off-by: Bruce Richardson > --- > =C2=A0devtools/test-meson-builds.sh | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > builds.sh > index 79109b757..3edc805f6 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -24,7 +24,7 @@ build () # > =C2=A0{ > =C2=A0 builddir=3D$1 > =C2=A0 shift > - if [ ! -d "$builddir" ] ; then > + if [ ! -f "$builddir/build.ninja" ] ; then > =C2=A0 options=3D"--werror -Dexamples=3Dall $*" > =C2=A0 echo "$MESON $options $srcdir $builddir" > =C2=A0 $MESON $options $srcdir $builddir Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi