From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix incorrect variable name in error message
Date: Thu, 10 Jan 2019 13:10:22 +0000 [thread overview]
Message-ID: <1547125822.16085.3.camel@debian.org> (raw)
In-Reply-To: <20190110102919.53188-1-bruce.richardson@intel.com>
On Thu, 2019-01-10 at 10:29 +0000, Bruce Richardson wrote:
> The variable name in the error message had an extra '_' which caused
> an actual meson error when the message would otherwise be printed to
> give meaningful information about what was going wrong.
>
> Fixes: 203b61dc5e18 ("build: improve error message for missing
> dependency")
> CC: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/meson.build b/lib/meson.build
> index a2dd52e17..93d7901d4 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -79,7 +79,7 @@ foreach l:libraries
> foreach d:deps
> if not is_variable('shared_rte_' +
> d)
> error('Missing dependency '
> + d +
> - ' for library ' +
> lib_name)
> + ' for library ' +
> libname)
> endif
> shared_deps +=
> [get_variable('shared_rte_' + d)]
> static_deps +=
> [get_variable('static_rte_' + d)]
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2019-01-10 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 10:29 [dpdk-dev] " Bruce Richardson
2019-01-10 13:10 ` Luca Boccassi [this message]
2019-01-14 11:05 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547125822.16085.3.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).