From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com
 [209.85.128.49]) by dpdk.org (Postfix) with ESMTP id F198A1B5C1;
 Thu, 10 Jan 2019 14:10:23 +0100 (CET)
Received: by mail-wm1-f49.google.com with SMTP id p6so11963324wmc.1;
 Thu, 10 Jan 2019 05:10:23 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:content-transfer-encoding:mime-version;
 bh=EUj95FSmbfWkTgyxRZqbNppS3vq685xPZ0iWv3Ph4O4=;
 b=KqfLy3NHpga4ebiByfQmBW/nchpzgtNdBkJz374acngVOybNR/UYJ8UbmSeI+EJRaW
 Fj66UsEkhZw2VJ0Q8rWQX2IeWsKOXkhl01NlbcUwOBiF70OmuGLG1qvgeR2tPHWwN/Yx
 csWAz+AsW2demPZr3JnvEePVRIgwVQjbApXr8QQS91erGaZVDQACKjrq+za/FJeJbLQR
 28ZkbosyibKU1VjdPsLKoYUScK6ftmPxj27kQqUfLrRkkMjl6hGhQpB2yrblI7WulN72
 rldD1eiY6OMr9+pzMYoy3GXWCV5minYNxRaLDZBUs+K958ZXpIjpwXkeEa8dsPNA7ci3
 t9CA==
X-Gm-Message-State: AJcUukeufDDbeir94tzFpMU73e5unZK/froZqQJYwhfGB7XmGtEVUhfz
 +sQazo4vaPFAj8KGTJLoZFg=
X-Google-Smtp-Source: ALg8bN6ZXlh0U6RtJwECes/cpinZMwkuLHkbxs1SMU67KZrclzmitr4CNiixv3JWUPQuJoq9TauRQA==
X-Received: by 2002:a1c:70b:: with SMTP id 11mr10243325wmh.74.1547125823609;
 Thu, 10 Jan 2019 05:10:23 -0800 (PST)
Received: from localhost ([2001:1be0:110d:fcfe:132c:a71a:1896:1395])
 by smtp.gmail.com with ESMTPSA id o5sm26387808wmg.25.2019.01.10.05.10.22
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Thu, 10 Jan 2019 05:10:22 -0800 (PST)
Message-ID: <1547125822.16085.3.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Date: Thu, 10 Jan 2019 13:10:22 +0000
In-Reply-To: <20190110102919.53188-1-bruce.richardson@intel.com>
References: <20190110102919.53188-1-bruce.richardson@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix incorrect variable
 name in error message
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2019 13:10:24 -0000

On Thu, 2019-01-10 at 10:29 +0000, Bruce Richardson wrote:
> The variable name in the error message had an extra '_' which caused
> an actual meson error when the message would otherwise be printed to
> give meaningful information about what was going wrong.
>=20
> Fixes: 203b61dc5e18 ("build: improve error message for missing
> dependency")
> CC: stable@dpdk.org
>=20
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> =C2=A0lib/meson.build | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/lib/meson.build b/lib/meson.build
> index a2dd52e17..93d7901d4 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -79,7 +79,7 @@ foreach l:libraries
> =C2=A0			foreach d:deps
> =C2=A0				if not is_variable('shared_rte_' +
> d)
> =C2=A0					error('Missing dependency '
> + d +
> -						' for library ' +
> lib_name)
> +						' for library ' +
> libname)
> =C2=A0				endif
> =C2=A0				shared_deps +=3D
> [get_variable('shared_rte_' + d)]
> =C2=A0				static_deps +=3D
> [get_variable('static_rte_' + d)]

Acked-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi