From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id DB3E31BC00 for ; Fri, 11 Jan 2019 16:04:40 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id p4so15530827wrt.7 for ; Fri, 11 Jan 2019 07:04:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=UNVx+jlNmAtyVNftJjldy1h51UVibSDKKFy0IzfpS2s=; b=B5QEzasdiCQoukHeN11aN0TQWDOqu8Vz96B7XCiR6ZnJXlvkfWH5XfLjjYyJPl6/3K STutG+MFxXvMo/6ZE49sgtPkJtiqWrQZMtQm4c3ngyJq9TnytWYD2Oinmg0xf7UPdPrv GNnoPKC5fZD+81BiSUybljK/Ky0hkUzqDB8MfW+eN4G8f9BCKVD7467TDsFnEWNniPWT 0K13x5D0a07QCLLGXyIB4c7h78jSJCdbIjqUhRQmB4H4K/uAypzgZ8xxqJjD4NsCNZde 6FnVrInJEn9HeJEcD4JaJi67bRhzNMAwl35JxOWbnxaPIEVZiu3yMnVoQqwKyuInXzp9 dJ/w== X-Gm-Message-State: AJcUukfoowiRuhlzI9rHstUTpKnKDuMwR/tE7xyTvaPf9uie1WxKG4fG t3nx0M3VOrxSqWu0eJhFuM0= X-Google-Smtp-Source: ALg8bN4ZBzuRtcM+4+IUssgFuSWly6PN9nUfE3rxT8BUu2TJRQjoyY91UeEBBExHARxOV9xKD+iqDA== X-Received: by 2002:adf:f149:: with SMTP id y9mr14881179wro.284.1547219080426; Fri, 11 Jan 2019 07:04:40 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id t76sm23290509wme.33.2019.01.11.07.04.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 07:04:39 -0800 (PST) Message-ID: <1547219078.4501.16.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org Date: Fri, 11 Jan 2019 15:04:38 +0000 In-Reply-To: <20190111143022.GC15912@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190111123809.8789-1-bluca@debian.org> <20190111123809.8789-3-bluca@debian.org> <20190111142700.GB15912@bricha3-MOBL.ger.corp.intel.com> <20190111143022.GC15912@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] build: bump minimum Meson to 0.47.1 and use dependency() for libbsd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 15:04:41 -0000 On Fri, 2019-01-11 at 14:30 +0000, Bruce Richardson wrote: > On Fri, Jan 11, 2019 at 02:27:01PM +0000, Bruce Richardson wrote: > > On Fri, Jan 11, 2019 at 12:38:09PM +0000, Luca Boccassi wrote: > > > Move libbsd inclusion to librte_eal, so that all other libraries > > > and > > > PMDs will inherit it, and librte_cmdline which is built before > > > librte_eal. > > > Bump Meson dependency to 0.47.1, to avoid bug where the linker > > > flag of > > > the dependency gets replicated again and again. > > >=20 > > > Signed-off-by: Luca Boccassi > > > --- > > > v2: bump meson minimum version to 0.47.1 to avoid meson bug, and > > > move > > > =C2=A0=C2=A0=C2=A0=C2=A0libbsd dependency to eal and cmdline > > >=20 > > > =C2=A0config/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 10 +++++----- > > > =C2=A0lib/librte_cmdline/meson.build |=C2=A0=C2=A04 ++++ > > > =C2=A0lib/librte_eal/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0= =C2=A03 +++ > > > =C2=A0meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2= =A0=C2=A02 +- > > > =C2=A04 files changed, 13 insertions(+), 6 deletions(-) > > >=20 > >=20 > > There are some meson version checks in the code that can be removed > > as > > part of this change: > >=20 > > $ git grep meson.version > > drivers/meson.build:=C2=A0=C2=A0=C2=A0=C2=A0if > > meson.version().version_compare('>=3D0.47') > > kernel/linux/meson.build:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if > > meson.version().version_compare('>=3D0.44') > > kernel/linux/meson.build:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if > > meson.version().version_compare('>=3D0.44') > > meson.build:=C2=A0=C2=A0=C2=A0=C2=A0meson_version: '>=3D 0.41' > > meson.build:if meson.version().version_compare('>=3D0.47') > >=20 >=20 > Thinking on this more, I think the version bump to 0.47 should be > done in a > separate standalone patch at the start of this set. Then the other > patches > can be based on that. >=20 > /Bruce Ok, will remove those checks in v3 and move the bump to a different patch. I'll put it second, as the first patch is really not related to the version and it's stand-alone (and marked for stable), I was just too lazy to do 2 series :-) --=20 Kind regards, Luca Boccassi