From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id A17CE1B9E4 for ; Fri, 11 Jan 2019 17:14:51 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id j2so15846952wrw.1 for ; Fri, 11 Jan 2019 08:14:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=1YbQwvi5IrWXD2OGxwBZGMufET2KnKCLpH8FAx7kO9g=; b=iNp/4qPjX/KQJtV3sYaSDhx6668ySU9EAn69uiSeNlo74UZAqNkobRcCX0zSTxMi7G JvgKAmK0rsotc8zlkRFDdvRg8nxQTGurOP1tOUL0m7WQRU/mj8M3VfZEUIFN/5UvF3Sw cqw62UKNM5+8vrgWkOJcxorFHI5lpAquBdNVW6+kynEWlEc8qfOhyKcgqcMD35HLZpCK NCqUt4yTNyLdomPiq3CnobQwwdGknmcretIUqwpy0ZfzVZSXPZRd24PB300hAoQJT2j/ afiZT6KmHy4jmxtercsO3aEnPGs1MLW5Bh8E6zoRW4tCCmlcKbDeLFREvuM62YUYPqh5 Fosw== X-Gm-Message-State: AJcUukeMLz4pupaUr8dH91/VrfQzQ02k70AvZ/ea+w0o/1KNzmml4tvi y8kMBktv3rnb8vfVfI7A4VP9B/e+oNc= X-Google-Smtp-Source: ALg8bN5QC4Ncg3oK8L747WcSpqorfXnuHxtkWk3OIe06YIduTsXM9IBu4Fo3lZtK/CBIIdMd7+3Uog== X-Received: by 2002:adf:f5d1:: with SMTP id k17mr15122089wrp.59.1547223291351; Fri, 11 Jan 2019 08:14:51 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id h184sm8812570wmf.0.2019.01.11.08.14.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 08:14:50 -0800 (PST) Message-ID: <1547223289.4501.17.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org Date: Fri, 11 Jan 2019 16:14:49 +0000 In-Reply-To: <20190111155032.GB10780@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190111123809.8789-1-bluca@debian.org> <20190111123809.8789-3-bluca@debian.org> <20190111142700.GB15912@bricha3-MOBL.ger.corp.intel.com> <20190111143022.GC15912@bricha3-MOBL.ger.corp.intel.com> <1547219078.4501.16.camel@debian.org> <20190111155032.GB10780@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] build: bump minimum Meson to 0.47.1 and use dependency() for libbsd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 16:14:51 -0000 On Fri, 2019-01-11 at 15:50 +0000, Bruce Richardson wrote: > On Fri, Jan 11, 2019 at 03:04:38PM +0000, Luca Boccassi wrote: > > On Fri, 2019-01-11 at 14:30 +0000, Bruce Richardson wrote: > > > On Fri, Jan 11, 2019 at 02:27:01PM +0000, Bruce Richardson wrote: > > > > On Fri, Jan 11, 2019 at 12:38:09PM +0000, Luca Boccassi wrote: > > > > > Move libbsd inclusion to librte_eal, so that all other > > > > > libraries > > > > > and > > > > > PMDs will inherit it, and librte_cmdline which is built > > > > > before > > > > > librte_eal. > > > > > Bump Meson dependency to 0.47.1, to avoid bug where the > > > > > linker > > > > > flag of > > > > > the dependency gets replicated again and again. > > > > >=20 > > > > > Signed-off-by: Luca Boccassi > > > > > --- > > > > > v2: bump meson minimum version to 0.47.1 to avoid meson bug, > > > > > and > > > > > move > > > > > =C2=A0=C2=A0=C2=A0=C2=A0libbsd dependency to eal and cmdline > > > > >=20 > > > > > =C2=A0config/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 10 +++++----- > > > > > =C2=A0lib/librte_cmdline/meson.build |=C2=A0=C2=A04 ++++ > > > > > =C2=A0lib/librte_eal/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|= =C2=A0=C2=A03 +++ > > > > > =C2=A0meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|= =C2=A0=C2=A02 +- > > > > > =C2=A04 files changed, 13 insertions(+), 6 deletions(-) > > > > >=20 > > > >=20 > > > > There are some meson version checks in the code that can be > > > > removed > > > > as > > > > part of this change: > > > >=20 > > > > $ git grep meson.version > > > > drivers/meson.build:=C2=A0=C2=A0=C2=A0=C2=A0if > > > > meson.version().version_compare('>=3D0.47') > > > > kernel/linux/meson.build:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= if > > > > meson.version().version_compare('>=3D0.44') > > > > kernel/linux/meson.build:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if > > > > meson.version().version_compare('>=3D0.44') > > > > meson.build:=C2=A0=C2=A0=C2=A0=C2=A0meson_version: '>=3D 0.41' > > > > meson.build:if meson.version().version_compare('>=3D0.47') > > > >=20 > > >=20 > > > Thinking on this more, I think the version bump to 0.47 should be > > > done in a > > > separate standalone patch at the start of this set. Then the > > > other > > > patches > > > can be based on that. > > >=20 > > > /Bruce > >=20 > > Ok, will remove those checks in v3 and move the bump to a different > > patch. I'll put it second, as the first patch is really not related > > to > > the version and it's stand-alone (and marked for stable), I was > > just > > too lazy to do 2 series :-) > >=20 > > --=C2=A0 > > Kind regards, > > Luca Boccassi >=20 > I don't expect the version bump to happen for 19.02, so if you want > the > first patch to go into that release, it probably needs to be > standalone. >=20 > /Bruce Ok, will do that. --=20 Kind regards, Luca Boccassi