From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id E83DB2C37; Mon, 14 Jan 2019 12:07:03 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id p6so8382121wmc.1; Mon, 14 Jan 2019 03:07:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=1BEfJammh6eizOCf+ukPZaOgNKREnFKcXrB8L1wl4lQ=; b=FnDu2FBBaEIMjniErjNo3JImBYJbjyUewk3evaXCruHxCYPpsvut5Y2YY9lIWVvBU9 4PwYQF9nyKAqquWDcLX+rZ3cvdHLRwg6oOgBqSMvm4QYzBM9HCzDvNLRWwKlfgP/yjOD dWaqAClV0G+xMmeAVfgjhGU3jVUtcirlzAqZGTHEN8YuQYH6fLMB4rgY07X3O3OktVpD vuETgu8YUknR+c5i4IikqCtHwVCmamXPNoky7Cc27p8VHyrbzDTemWQeM7OkdJs29zRS dFVLBjiQIwvj3YDw/9hS2NNzBRUk6YZA7BSLyZkMP/xMb+rn2F0+Y9gvRJQrxcToMDlI uiVg== X-Gm-Message-State: AJcUukf2kZPMRBvkmo2Q6g5Kjx0g/55S3SBNPJguQuRYlfAYn6lVT3T2 ZYF4M58vtr1jMRTCGWGVMeE= X-Google-Smtp-Source: ALg8bN45rl6nGfdn9f5DQQANKgbxNROyxnvntaanFhAIYxjvz3EU0Y+egBbVhEg2Ire+GnvyCgCdsw== X-Received: by 2002:a1c:650b:: with SMTP id z11mr11510869wmb.23.1547464023353; Mon, 14 Jan 2019 03:07:03 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id v8sm95212278wrq.53.2019.01.14.03.07.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 03:07:02 -0800 (PST) Message-ID: <1547464022.4501.29.camel@debian.org> From: Luca Boccassi To: Jerin Jacob Kollanukkaran , "dev@dpdk.org" Cc: "gavin.hu@arm.com" , "stable@dpdk.org" , "viktorin@rehivetech.com" , "bruce.richardson@intel.com" Date: Mon, 14 Jan 2019 11:07:02 +0000 In-Reply-To: <9cbbf7e4ef683b8df7dea046fc1dde0e49868253.camel@marvell.com> References: <20181224125627.25690-1-bluca@debian.org> <20190107141130.24360-1-bluca@debian.org> <1547203539.4501.7.camel@debian.org> <1e16e55dacafcefe57861635a8a7c5d4729326fd.camel@marvell.com> <1547459910.4501.26.camel@debian.org> <9cbbf7e4ef683b8df7dea046fc1dde0e49868253.camel@marvell.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3] build: use generic march on arm64 when using 'default' machine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 11:07:04 -0000 On Mon, 2019-01-14 at 10:35 +0000, Jerin Jacob Kollanukkaran wrote: > On Mon, 2019-01-14 at 09:58 +0000, Luca Boccassi wrote: > > On Mon, 2019-01-14 at 08:09 +0000, Jerin Jacob Kollanukkaran wrote: > > > On Fri, 2019-01-11 at 10:45 +0000, Luca Boccassi wrote: > > > > External Email > > > >=20 > > > > --------------------------------------------------------------- > > > > ---- > > > > --- > > > > On Mon, 2019-01-07 at 14:11 +0000, Luca Boccassi wrote: > > > > > When building for generic distribution we need a stable > > > > > baseline > > > > > architecture, or depending on the build worker the result > > > > > will > > > > > vary. > > > > >=20 > > > > > Force the default flags if the user explicitly sets > > > > > machine=3Ddefault > > > > > at configuration time. > > > > >=20 > > > > > Fixes: b1d48c41189a ("build: support ARM with meson") > > > > > Cc: stable@dpdk.org > > > > >=20 > > > > > Signed-off-by: Luca Boccassi > > > > > Acked-by: Bruce Richardson > > > > > --- > > > > > v2: fix typo in commit message, remove variable used only > > > > > once > > > > > v3: put back temporary variable, as "machine" gets > > > > > overwritten > > > > > =C2=A0=C2=A0=C2=A0=C2=A0by the function and loses the original va= lue before we > > > > > need > > > > > =C2=A0=C2=A0=C2=A0=C2=A0it. > > > > >=20 > > > > > =C2=A0config/arm/meson.build | 7 ++++++- > > > > > =C2=A01 file changed, 6 insertions(+), 1 deletion(-) > > > > >=20 > > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > > > > index dae55d6b2..614139534 100644 > > > > > --- a/config/arm/meson.build > > > > > +++ b/config/arm/meson.build > > > > > @@ -6,6 +6,7 @@ > > > > > =C2=A0march_opt =3D '-march=3D@0@'.format(machine) > > > > > =C2=A0 > > > > > =C2=A0arm_force_native_march =3D false > > > > > +arm_force_default_march =3D (machine =3D=3D 'default') > > > > > =C2=A0 > > > > > =C2=A0machine_args_generic =3D [ > > > > > =C2=A0 ['default', ['-march=3Darmv8-a+crc+crypto']], > > > > > @@ -105,7 +106,11 @@ else > > > > > =C2=A0 cmd_generic =3D ['generic', '', '', 'default', ''] > > > > > =C2=A0 cmd_output =3D cmd_generic # Set generic by default > > > > > =C2=A0 machine_args =3D [] # Clear previous machine args > > > > > - if not meson.is_cross_build() > > > > > + if arm_force_default_march and not > > > > > meson.is_cross_build() > > > > > + machine =3D impl_generic > > > > > + cmd_output =3D cmd_generic > > > > > + impl_pn =3D 'default' > > > > > + elif not meson.is_cross_build() > > > > > =C2=A0 # The script returns ['Implementer', > > > > > 'Variant', > > > > > 'Architecture', > > > > > =C2=A0 # 'Primary Part number', 'Revision'] > > > > > =C2=A0 detect_vendor =3D find_program(join_paths( > > > >=20 > > > > Any chance for a quick review from the arm maintainers/devs? > > > > Thanks! > > >=20 > > > Looks good. > > >=20 > > > Could you please document the procedure to build generic image > > > some > > > where in the DPDK documentation. > > >=20 > > > I guess the procedure will be same for x86 and arm64. Right? > >=20 > > The "machine" meson option is already described in > > meson_options.txt, > > is that enough? >=20 > I meant, Documenting the steps to create the generic image i.e - > Dmachine=3Ddefault scheme to use generic build for meson based > distribution build. >=20 > Is it same for x86 too? >=20 > meson configure -Dmachine=3Ddefault > meson build > cd build > ninja > ninja install Yes that's correct, for any architecture "-Dmachine=3Ddefault" will pick a stable baseline. I can send a separate patch to update the doc with that command. --=20 Kind regards, Luca Boccassi