* [dpdk-dev] [PATCH] doc: fix an error in ifc NIC document
@ 2019-01-17 14:50 Rami Rosen
2019-01-17 15:57 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-01-18 1:59 ` [dpdk-dev] " Wang, Xiao W
0 siblings, 2 replies; 4+ messages in thread
From: Rami Rosen @ 2019-01-17 14:50 UTC (permalink / raw)
To: dev; +Cc: stable, xiao.w.wang, Rami Rosen
This patch fixes an error in ifc NIC document; a previous patch
changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD
instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD,
but the ifc NIC doc file remained with the old name.
Fixes: 4b614e9504a1 ("net/ifc: make driver name consistent")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
doc/guides/nics/ifc.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/nics/ifc.rst b/doc/guides/nics/ifc.rst
index bdf7b4e..317d9ff 100644
--- a/doc/guides/nics/ifc.rst
+++ b/doc/guides/nics/ifc.rst
@@ -19,7 +19,7 @@ Config File Options
The following option can be modified in the ``config`` file.
-- ``CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD`` (default ``y`` for linux)
+- ``CONFIG_RTE_LIBRTE_IFC_PMD`` (default ``y`` for linux)
Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix an error in ifc NIC document
2019-01-17 14:50 [dpdk-dev] [PATCH] doc: fix an error in ifc NIC document Rami Rosen
@ 2019-01-17 15:57 ` Ferruh Yigit
2019-01-18 1:59 ` [dpdk-dev] " Wang, Xiao W
1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2019-01-17 15:57 UTC (permalink / raw)
To: Rami Rosen, dev; +Cc: stable, xiao.w.wang
On 1/17/2019 2:50 PM, Rami Rosen wrote:
> This patch fixes an error in ifc NIC document; a previous patch
> changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD
> instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD,
> but the ifc NIC doc file remained with the old name.
>
> Fixes: 4b614e9504a1 ("net/ifc: make driver name consistent")
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] doc: fix an error in ifc NIC document
2019-01-17 14:50 [dpdk-dev] [PATCH] doc: fix an error in ifc NIC document Rami Rosen
2019-01-17 15:57 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-01-18 1:59 ` Wang, Xiao W
2019-01-18 8:39 ` Ferruh Yigit
1 sibling, 1 reply; 4+ messages in thread
From: Wang, Xiao W @ 2019-01-18 1:59 UTC (permalink / raw)
To: Rami Rosen, dev, Yigit, Ferruh; +Cc: stable
Hi,
> -----Original Message-----
> From: Rami Rosen [mailto:ramirose@gmail.com]
> Sent: Thursday, January 17, 2019 10:51 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>; Rami Rosen
> <ramirose@gmail.com>
> Subject: [PATCH] doc: fix an error in ifc NIC document
>
> This patch fixes an error in ifc NIC document; a previous patch
> changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD
> instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD,
> but the ifc NIC doc file remained with the old name.
>
> Fixes: 4b614e9504a1 ("net/ifc: make driver name consistent")
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> doc/guides/nics/ifc.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/nics/ifc.rst b/doc/guides/nics/ifc.rst
> index bdf7b4e..317d9ff 100644
> --- a/doc/guides/nics/ifc.rst
> +++ b/doc/guides/nics/ifc.rst
> @@ -19,7 +19,7 @@ Config File Options
>
> The following option can be modified in the ``config`` file.
>
> -- ``CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD`` (default ``y`` for linux)
> +- ``CONFIG_RTE_LIBRTE_IFC_PMD`` (default ``y`` for linux)
>
> Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
Could we also squash below fix into this patch? Or we make a separate one since this patch is applied already.
- Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
+ Toggle compilation of the ``librte_pmd_ifc`` driver.
BRs,
Xiao
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] doc: fix an error in ifc NIC document
2019-01-18 1:59 ` [dpdk-dev] " Wang, Xiao W
@ 2019-01-18 8:39 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2019-01-18 8:39 UTC (permalink / raw)
To: Wang, Xiao W, Rami Rosen, dev; +Cc: stable
On 1/18/2019 1:59 AM, Wang, Xiao W wrote:
> Hi,
>
>> -----Original Message-----
>> From: Rami Rosen [mailto:ramirose@gmail.com]
>> Sent: Thursday, January 17, 2019 10:51 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>; Rami Rosen
>> <ramirose@gmail.com>
>> Subject: [PATCH] doc: fix an error in ifc NIC document
>>
>> This patch fixes an error in ifc NIC document; a previous patch
>> changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD
>> instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD,
>> but the ifc NIC doc file remained with the old name.
>>
>> Fixes: 4b614e9504a1 ("net/ifc: make driver name consistent")
>> Cc: stable@dpdk.org
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>> ---
>> doc/guides/nics/ifc.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/doc/guides/nics/ifc.rst b/doc/guides/nics/ifc.rst
>> index bdf7b4e..317d9ff 100644
>> --- a/doc/guides/nics/ifc.rst
>> +++ b/doc/guides/nics/ifc.rst
>> @@ -19,7 +19,7 @@ Config File Options
>>
>> The following option can be modified in the ``config`` file.
>>
>> -- ``CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD`` (default ``y`` for linux)
>> +- ``CONFIG_RTE_LIBRTE_IFC_PMD`` (default ``y`` for linux)
>>
>> Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
>
> Could we also squash below fix into this patch? Or we make a separate one since this patch is applied already.
>
> - Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
> + Toggle compilation of the ``librte_pmd_ifc`` driver.
Thanks for update.
Squashed in next-net, please check.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-18 8:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 14:50 [dpdk-dev] [PATCH] doc: fix an error in ifc NIC document Rami Rosen
2019-01-17 15:57 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-01-18 1:59 ` [dpdk-dev] " Wang, Xiao W
2019-01-18 8:39 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).