DPDK patches and discussions
 help / color / mirror / Atom feed
From: Fiona Trahe <fiona.trahe@intel.com>
To: dev@dpdk.org
Cc: pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com,
	akhil.goyal@nxp.com, paul.e.luse@intel.com
Subject: [dpdk-dev] [PATCH v2] compressdev: add feature flag to specify where processing is done
Date: Thu, 17 Jan 2019 17:36:23 +0000	[thread overview]
Message-ID: <1547746583-13832-1-git-send-email-fiona.trahe@intel.com> (raw)
In-Reply-To: <1542677988-3876-1-git-send-email-fiona.trahe@intel.com>

A new device feature flag, RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE
is added. A PMD should set this if the bulk of the
processing is done during the dequeue. It should leave it
cleared if the bulk of the processing is done during the
enqueue (default).
Applications can use this as a hint for tuning.

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 lib/librte_compressdev/rte_compressdev.c | 2 ++
 lib/librte_compressdev/rte_compressdev.h | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/lib/librte_compressdev/rte_compressdev.c b/lib/librte_compressdev/rte_compressdev.c
index 10101ebbe..338134bdf 100644
--- a/lib/librte_compressdev/rte_compressdev.c
+++ b/lib/librte_compressdev/rte_compressdev.c
@@ -66,6 +66,8 @@ rte_compressdev_get_feature_name(uint64_t flag)
 		return "CPU_AVX512";
 	case RTE_COMPDEV_FF_CPU_NEON:
 		return "CPU_NEON";
+	case RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE:
+		return "OP_DONE_IN_DEQ";
 	default:
 		return NULL;
 	}
diff --git a/lib/librte_compressdev/rte_compressdev.h b/lib/librte_compressdev/rte_compressdev.h
index 7b68170a5..d3c0000f0 100644
--- a/lib/librte_compressdev/rte_compressdev.h
+++ b/lib/librte_compressdev/rte_compressdev.h
@@ -73,6 +73,12 @@ rte_compressdev_capability_get(uint8_t dev_id,
 /**< Utilises CPU SIMD AVX512 instructions */
 #define	RTE_COMPDEV_FF_CPU_NEON			(1ULL << 5)
 /**< Utilises CPU NEON instructions */
+#define RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE	(1ULL << 6)
+/**< A PMD should set this if the bulk of the
+ * processing is done during the dequeue. It should leave it
+ * cleared if the processing is done during the enqueue (default).
+ * Applications can use this as a hint for tuning.
+ */
 
 /**
  * Get the name of a compress device feature flag.
-- 
2.13.6

  parent reply	other threads:[~2019-01-17 17:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20  1:39 [dpdk-dev] [PATCH] " Fiona Trahe
2018-11-20  1:53 ` Stephen Hemminger
2018-11-20 16:25   ` Trahe, Fiona
2018-11-20 18:07     ` Stephen Hemminger
2018-12-18 14:43       ` Trahe, Fiona
2018-12-19  5:47         ` Verma, Shally
2018-12-19 17:09           ` Trahe, Fiona
2019-01-10 18:46             ` De Lara Guarch, Pablo
2019-01-12  6:47               ` Verma, Shally
2019-01-16 11:21               ` Shally Verma
2019-01-16 11:36                 ` Trahe, Fiona
2019-01-16 12:09                   ` Shally Verma
2019-01-16 12:44                     ` Trahe, Fiona
2019-01-16 13:47                       ` Shally Verma
2018-11-20  5:17 ` Verma, Shally
2018-11-20 16:40   ` Trahe, Fiona
2019-01-17 17:36 ` Fiona Trahe [this message]
2019-02-20 16:00   ` [dpdk-dev] [PATCH v2] " Shally Verma
2019-03-22 15:09     ` Akhil Goyal
2019-03-22 15:09       ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1547746583-13832-1-git-send-email-fiona.trahe@intel.com \
    --to=fiona.trahe@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=paul.e.luse@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).