[dpdk-dev] [PATCH] compress/isal: fix build with old library version

[dpdk-dev] [PATCH] compress/isal: fix build with old library version

[Lee Daly]

This patch removes an unnecessary flag which was breaking the
build with older versions of the ISA-L library (v2.23 and older)
and replace with a more appropriate flag which is present
in older versions of library.

Fixes: bd03d3f1e4f1 ("compress/isal: enable checksum support")

Signed-off-by: Lee Daly <lee.daly@intel.com>
---
 drivers/compress/isal/isal_compress_pmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/compress/isal/isal_compress_pmd.c b/drivers/compress/isal/isal_compress_pmd.c
index b610e90..4748238 100644
--- a/drivers/compress/isal/isal_compress_pmd.c
+++ b/drivers/compress/isal/isal_compress_pmd.c
@@ -195,10 +195,10 @@ isal_comp_set_priv_xform_parameters(struct isal_priv_xform *priv_xform,
 			priv_xform->decompress.chksum = ISAL_DEFLATE;
 			break;
 		case(RTE_COMP_CHECKSUM_CRC32):
-			priv_xform->decompress.chksum = ISAL_GZIP_NO_HDR_VER;
+			priv_xform->decompress.chksum = ISAL_GZIP_NO_HDR;
 			break;
 		case(RTE_COMP_CHECKSUM_ADLER32):
-			priv_xform->decompress.chksum = ISAL_ZLIB_NO_HDR_VER;
+			priv_xform->decompress.chksum = ISAL_ZLIB_NO_HDR;
 			break;
 		case(RTE_COMP_CHECKSUM_CRC32_ADLER32):
 			ISAL_PMD_LOG(ERR, "Combined CRC and ADLER checksum not"
-- 
2.7.4

Re: [dpdk-dev] [PATCH] compress/isal: fix build with old library version

[Van Haaren, Harry]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lee Daly
> Sent: Thursday, January 17, 2019 9:11 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>
> Cc: dev@dpdk.org; Daly, Lee <lee.daly@intel.com>
> Subject: [dpdk-dev] [PATCH] compress/isal: fix build with old library
> version
> 
> This patch removes an unnecessary flag which was breaking the
> build with older versions of the ISA-L library (v2.23 and older)
> and replace with a more appropriate flag which is present
> in older versions of library.
> 
> Fixes: bd03d3f1e4f1 ("compress/isal: enable checksum support")
> 
> Signed-off-by: Lee Daly <lee.daly@intel.com>


Fixed my build here with ISA-L 2.22;

Tested-by: Harry van Haaren <harry.van.haaren@intel.com>

Re: [dpdk-dev] [PATCH] compress/isal: fix build with old library version

[Thomas Monjalon]

> > This patch removes an unnecessary flag which was breaking the
> > build with older versions of the ISA-L library (v2.23 and older)
> > and replace with a more appropriate flag which is present
> > in older versions of library.
> > 
> > Fixes: bd03d3f1e4f1 ("compress/isal: enable checksum support")
> > 
> > Signed-off-by: Lee Daly <lee.daly@intel.com>
> 
> 
> Fixed my build here with ISA-L 2.22;
> 
> Tested-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied, thanks