DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 7/7] app/testpmd: rework for displaying different size of RX descriptors
Date: Mon, 23 Jun 2014 17:43:41 +0200	[thread overview]
Message-ID: <1548077.iev3PggAHf@xps13> (raw)
In-Reply-To: <1403528231-4099-8-git-send-email-helin.zhang@intel.com>

Hi Helin,

Thanks for this new patchset version.

2014-06-23 20:57, Helin Zhang:
> i40e supports 16 and 32 bytes RX descriptors which can be configured.
> It needs to check the driver type and the configuration to determine
> if 16 or 32 bytes RX descriptors is being used, for reading and
> displaying the different sizes of RX descriptors.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> Acked-by: Jing Chen <jing.d.chen@intel.com>
> Acked-by: Cunming Liang <cunming.liang@intel.com>

Just before applying theses patches, I checked with checkpatch.pl which warned 
me about this:

> +		ring_rxd_display_dword(rte_le_to_cpu_64(\
> +				ring[desc_id].lo_dword));
> +		ring_rxd_display_dword(rte_le_to_cpu_64(\
> +				ring[desc_id].hi_dword));
> +		ring_rxd_display_dword(rte_le_to_cpu_64(\
> +				ring[desc_id].resv1));
> +		ring_rxd_display_dword(rte_le_to_cpu_64(\
> +				ring[desc_id].resv2));

WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations

Could you remove it please?

Thanks
-- 
Thomas

      reply	other threads:[~2014-06-23 15:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 12:57 [dpdk-dev] [PATCH v2 0/7] enhancements for i40e Helin Zhang
2014-06-23 12:57 ` [dpdk-dev] [PATCH v2 1/7] i40e: fix for getting correct RSS hash result Helin Zhang
2014-06-23 12:57 ` [dpdk-dev] [PATCH v2 2/7] i40evf: remove an interface which is not used Helin Zhang
2014-06-23 12:57 ` [dpdk-dev] [PATCH v2 3/7] i40evf: fix for copying wrong size of link info Helin Zhang
2014-06-23 12:57 ` [dpdk-dev] [PATCH v2 4/7] i40e: fix for updating the hash lookup table of PF RSS Helin Zhang
2014-06-23 12:57 ` [dpdk-dev] [PATCH v2 5/7] i40e: double vlan should be specifically disabled by default Helin Zhang
2014-06-23 12:57 ` [dpdk-dev] [PATCH v2 6/7] i40e: ignore the failure of updating default macvlan filter Helin Zhang
2014-06-23 12:57 ` [dpdk-dev] [PATCH v2 7/7] app/testpmd: rework for displaying different size of RX descriptors Helin Zhang
2014-06-23 15:43   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1548077.iev3PggAHf@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).