From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 31566AFD6 for ; Mon, 23 Jun 2014 17:43:26 +0200 (CEST) Received: by mail-wg0-f49.google.com with SMTP id y10so6505134wgg.8 for ; Mon, 23 Jun 2014 08:43:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Ph1yzxI8n2S4cddOTv5yKCg2rRqx+FIyqzgsMy251gw=; b=P6dSY9GtTw7/crojCMPPuvS/2xGBQnPOb0VK0DXHJlEviebFFRex3MSHd9SoJVOJ1D Q4Ma3EbvKPD9SpJ15KXpzZO81SgUqKgp6jTl6HEsT00fJembXJN3Xxx4rO9BtRMuJk19 v2Vra1qOeSx/HdRfgGtlqWBvm5m8nOsDUJz5E5EEftynCmjhuGNHWGuPnr1h0YpBoZWI yvg8Q16SX9jsUAJBqWwK5l3Vlr7y8xdv6wyJIBkz2lMhtl94PNOrlAwBa5jxL4DINUGr bYrfI4JInNKZKWYJCIZbhWLU2n7CxJdSa3Zm3V36VI8Xuxu73FaWW3mTsu+C/977qCnm MjNg== X-Gm-Message-State: ALoCoQnlIDkFIa9GSMoWtEbQgwfiv6GjsCOHBdHnep5wePhph+XaI34tuTyaDYB4IIhwKoItBfrp X-Received: by 10.194.175.106 with SMTP id bz10mr6193940wjc.96.1403538224351; Mon, 23 Jun 2014 08:43:44 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fh5sm34461453wic.9.2014.06.23.08.43.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jun 2014 08:43:43 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Mon, 23 Jun 2014 17:43:41 +0200 Message-ID: <1548077.iev3PggAHf@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1403528231-4099-8-git-send-email-helin.zhang@intel.com> References: <1403528231-4099-1-git-send-email-helin.zhang@intel.com> <1403528231-4099-8-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 7/7] app/testpmd: rework for displaying different size of RX descriptors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jun 2014 15:43:26 -0000 Hi Helin, Thanks for this new patchset version. 2014-06-23 20:57, Helin Zhang: > i40e supports 16 and 32 bytes RX descriptors which can be configured. > It needs to check the driver type and the configuration to determine > if 16 or 32 bytes RX descriptors is being used, for reading and > displaying the different sizes of RX descriptors. > > Signed-off-by: Helin Zhang > Acked-by: Jing Chen > Acked-by: Cunming Liang Just before applying theses patches, I checked with checkpatch.pl which warned me about this: > + ring_rxd_display_dword(rte_le_to_cpu_64(\ > + ring[desc_id].lo_dword)); > + ring_rxd_display_dword(rte_le_to_cpu_64(\ > + ring[desc_id].hi_dword)); > + ring_rxd_display_dword(rte_le_to_cpu_64(\ > + ring[desc_id].resv1)); > + ring_rxd_display_dword(rte_le_to_cpu_64(\ > + ring[desc_id].resv2)); WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations Could you remove it please? Thanks -- Thomas