* [dpdk-dev] [PATCH] net/mlx5: block RSS action without Rx queues
@ 2019-01-22 8:22 Dekel Peled
2019-01-24 11:15 ` Shahaf Shuler
0 siblings, 1 reply; 2+ messages in thread
From: Dekel Peled @ 2019-01-22 8:22 UTC (permalink / raw)
To: yskoh, shahafs; +Cc: dev, orika, dekelp
This patch modifies function mlx5_flow_validate_action_rss(), to
prevent the setting of rule with rss action, but without specifying
any queues.
For example:
flow create 0 ingress pattern end actions rss queues end / end
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index f91aecd..11213e2 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -947,6 +947,10 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,
return rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION_CONF,
NULL, "No Rx queues configured");
+ if (!rss->queue_num)
+ return rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION_CONF,
+ NULL, "No queues configured");
for (i = 0; i != rss->queue_num; ++i) {
if (!(*priv->rxqs)[rss->queue[i]])
return rte_flow_error_set
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: block RSS action without Rx queues
2019-01-22 8:22 [dpdk-dev] [PATCH] net/mlx5: block RSS action without Rx queues Dekel Peled
@ 2019-01-24 11:15 ` Shahaf Shuler
0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2019-01-24 11:15 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh; +Cc: dev, Ori Kam, Dekel Peled
Tuesday, January 22, 2019 10:22 AM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH] net/mlx5: block RSS action without Rx queues
>
> This patch modifies function mlx5_flow_validate_action_rss(), to prevent the
> setting of rule with rss action, but without specifying any queues.
> For example:
> flow create 0 ingress pattern end actions rss queues end / end
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-24 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 8:22 [dpdk-dev] [PATCH] net/mlx5: block RSS action without Rx queues Dekel Peled
2019-01-24 11:15 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).