From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 0BE72A3 for ; Tue, 22 Jan 2019 15:09:44 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id z5so27452652wrt.11 for ; Tue, 22 Jan 2019 06:09:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=/SQ+BvGc3/gq4BIVWdZx3n+36t+tegTo8lAINZ3xykw=; b=kwGnnoJHyiAHMQ2frjNev+q+9/PrIbQDvIigYbKrrn9nhzvDiIQX3UVn53ve638I8B 2ymXXbDzpa12aCHY/y95q7VTiZmMVSFAYylo1ahObnLeDrzth+u6rA13gcyEFBd7GBBn r5zh/Bs+OFh0A6JSeMyF7mlQRVqlo0BzXpS/LW4kqx03Fkig02NpKM5cdUSv+a7Fu+yt 0b3iXPeKccaImfNd0//jw7/Rcs+TGAYUTnXO6oyoFjM14Gpq5cta2EubbjoqJtMFH6ZI /+q9ly+beZ3L9o5L+bTbEt/XwLKAkqeSvWAzC44qcSfHtU+VJ5PRYMaa4woy7LqaL1lY ZoAA== X-Gm-Message-State: AJcUukeVAT502ystR/+LU+7Q3LCCTbxQwtcgPSidTOJtlE3CQxHzsQAf TSX8/nI0nAEhGv6bwPE2YP0= X-Google-Smtp-Source: ALg8bN7Im7WhrT8Y4guSqXqNY06FyzET6927I0yJA6hmLg7jGryQ8fHolzpIgkMAh8JPTOG+5Habxg== X-Received: by 2002:adf:e488:: with SMTP id i8mr34112077wrm.10.1548166183586; Tue, 22 Jan 2019 06:09:43 -0800 (PST) Received: from localhost ([2001:1be0:110d:fcfe:132c:a71a:1896:1395]) by smtp.gmail.com with ESMTPSA id v1sm130464563wrw.90.2019.01.22.06.09.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 06:09:42 -0800 (PST) Message-ID: <1548166181.8759.21.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org Date: Tue, 22 Jan 2019 14:09:41 +0000 In-Reply-To: <20190122134653.GB29548@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190122131054.25196-1-bluca@debian.org> <20190122131054.25196-2-bluca@debian.org> <20190122134653.GB29548@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/4] build: use dependency() instead of find_library() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 14:09:44 -0000 On Tue, 2019-01-22 at 13:46 +0000, Bruce Richardson wrote: > On Tue, Jan 22, 2019 at 01:10:52PM +0000, Luca Boccassi wrote: > > Whenever possible (if the library ships a pkg-config file) use > > meson's > > dependency() function to look for it, as it will automatically add > > it > > to the Requires.private list if needed, to allow for static builds > > to > > succeed for reverse dependencies of DPDK. Otherwise the recursive > > dependencies are not parsed, and users doing static builds have to > > resolve them manually by themselves. > > When using this API avoid additional checks that are superfluous > > and > > take extra time, and avoid adding the linker flag manually which > > causes > > it to be duplicated. > >=20 > > Signed-off-by: Luca Boccassi > > --- > > v2: split libbsd change in a separate commit, remove CC to stable > > =C2=A0=C2=A0=C2=A0=C2=A0as a meson bump will be required > > v4: update comment in drivers/meson.build to clarify role of > > =C2=A0=C2=A0=C2=A0=C2=A0pkgconfig_extra_libs > > v5: remove -lz from drivers/compress/zlib >=20 > How is this removal possible? Does drivers/compress/zlib no longer > depend > on libz, or is there a dependency added somewhere else in this patch > that > I'm missing? Similar question with the -lcrypto removal? >=20 > /Bruce Note that the removal is from the pkgconfig_extra_libs list - same for lcrypto. They use dependency() already, and the dep is added to the ext_deps, so the dependency comes in that way (and the right flags are picked via pkg-config). --=20 Kind regards, Luca Boccassi