From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A08871BAE1 for ; Thu, 26 Oct 2017 15:07:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BE46820BF5; Thu, 26 Oct 2017 09:07:30 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 26 Oct 2017 09:07:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=gJtiP72upFleIvaE5wjXDiXHEE R0JAASlwuii8SKghA=; b=ovtpR4++MSj77FrxBPBimQX+Gi0YZ1ATQLshxA37RC rSukIaLHm7xFg2eM98NLsTV7+I1fKnXwGvwC+k2PHfjKFo9pl3KHHZndTo4QzVp7 FBybC0bPl5izp+CONGy17vxfCPEkByfJkxBuNbFqyA/H7qCeRGX36k8hu/fSHYEm Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=gJtiP7 2upFleIvaE5wjXDiXHEER0JAASlwuii8SKghA=; b=MLVg48a/DQRmckfJEJyCeZ 6WpZ9PTFct9XWvoPC1sLgADKL0p7nBzPqS4wZWFn4WOP8fx4E+rT3pyW8F1yK1Px a897cGWhttLYLqYqNwi52oOc1AlmJ/v7mG11NA7ZLEStCQJaCz7oj2McizSgeuMz wx8Lkwdyobh7/TDEHVCcKKx1F2nb3xIEOipzTaPDAT9uvtYc7vc/QfQ2Fe4UxqdS RJtzsqH4t5eOpnxRQhufyt67UPC3hwP1QxU+MygpMxofA3L7hilRmfC4IRxTh3yO k+ko3cJzYFj9F+oxWXXXaT8Vw9Z88t/uUSd8IuMtaOYu2hwj7Bza8/J6bHPMYEPw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 641FD241D9; Thu, 26 Oct 2017 09:07:30 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: Radu Nicolau , David Marchand , dev@dpdk.org, Declan Doherty , Pablo de Lara , Hemant Agrawal , borisp@mellanox.com, aviadye@mellanox.com, sandeep.malik@nxp.com, Jerin Jacob , "Mcnamara, John" , "Ananyev, Konstantin" , shahafs@mellanox.com, Olivier Matz Date: Thu, 26 Oct 2017 15:07:29 +0200 Message-ID: <1548422.ftI5jb3vlP@xps> In-Reply-To: <8645d9c8-c2e6-b033-1438-97ef2021ccb2@nxp.com> References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com> <1837995.9rLZR0Gx80@xps> <8645d9c8-c2e6-b033-1438-97ef2021ccb2@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 13:07:31 -0000 26/10/2017 14:59, Akhil Goyal: > Hi Thomas, > > On 10/26/2017 6:03 PM, Thomas Monjalon wrote: > > 26/10/2017 14:28, Radu Nicolau: > >> > >> On 10/26/2017 12:39 PM, Thomas Monjalon wrote: > >>> 26/10/2017 13:27, David Marchand: > >>>> On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau wrote: > >>>>> On 10/26/2017 11:36 AM, David Marchand wrote: > >>>>>> On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau > >>>>>> wrote: > >>>>>>> --- a/drivers/net/ixgbe/Makefile > >>>>>>> +++ b/drivers/net/ixgbe/Makefile > >>>>>>> +ifneq ($(MAKECMDGOALS),clean) > >>>>>>> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y) > >>>>>>> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD") > >>>>>>> +endif > >>>>>>> +endif > >>>>>> This is a no go for me unless you explain how it is impossible to > >>>>>> disable it in the code. > >>>>>> > >>>>>> > >>>>> It can be disabled in the code, but as far as I know there is a general push > >>>>> back against having conditionally compiled code. I originally had the > >>>>> security sections in ixgbe PMD isolated, but the feedback was to have them > >>>>> always on. > >>>> In my mind, this was to stop having features enabled per pmd (and stop > >>>> the nightmare with 10 options in a pmd). > >>>> Having features globally enabled for all or nothing is still > >>>> acceptable, is it not ? > >>> Yes there is a config option for rte_security, > >>> and it is acceptable. > >>> The code depending on it must be ifdef'ed. > >> > >> Given that both ixgbe and dpaa2_sec are now security enabled PMDs, I > >> would go with Konstantin's proposal, have rte_security listed as a > >> dependency (instead of the explicit check). > > > > Please consider my request instead. > > Until now we are ifdef'ing code to allow disabling any lib. > > We are not going to change our mind during the last days of a release. > > Please just fix it for now. > > For dpaa2_sec we do not want to make the driver run without > rte_security. We do not see people using it without rte_security. Why not? > Will take the Makefile changes that Radu has done in 1st patch of this > series. Is it really a lot to ifdef? It is going to break compilation of DPDK for those who disable rte_security.