From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>, Peng Yu <penyu@amazon.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Ray Kinsella <mdr@ashroe.eu>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH] vhost: use colon in version.map
Date: Fri, 4 Mar 2022 13:57:38 +0000 [thread overview]
Message-ID: <15488661-2960-124b-304e-a6aaf09e0f71@intel.com> (raw)
In-Reply-To: <SN6PR11MB3504C8400986A2C649FBC9D89C049@SN6PR11MB3504.namprd11.prod.outlook.com>
On 3/3/2022 11:32 AM, Xia, Chenbo wrote:
>> -----Original Message-----
>> From: Peng Yu <penyu@amazon.com>
>> Sent: Tuesday, February 15, 2022 1:56 PM
>> To: dev@dpdk.org
>> Cc: Peng Yu <penyu@amazon.com>; Ray Kinsella <mdr@ashroe.eu>; Maxime Coquelin
>> <maxime.coquelin@redhat.com>; Xia, Chenbo <chenbo.xia@intel.com>
>> Subject: [PATCH] vhost: use colon in version.map
>>
>> The punctuation after the `global` keyword should be colon, not
>> semicolon. The default gcc linker accepts both colon and semicolon, but
>> the gold linker will report syntax error if we use semicolon after the
>> `global` keyword.
>>
>> Signed-off-by: Peng Yu <penyu@amazon.com>
>
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-03-04 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 5:55 Peng Yu
2022-03-03 11:32 ` Xia, Chenbo
2022-03-04 13:57 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15488661-2960-124b-304e-a6aaf09e0f71@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=mdr@ashroe.eu \
--cc=penyu@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).