From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A29133195 for ; Sun, 28 Oct 2018 11:21:50 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2CEF520B52; Sun, 28 Oct 2018 06:21:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 28 Oct 2018 06:21:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rxtB0PyZ+5MWBV8wtF++yrjedBctCQpwdLEmN96z8ks=; b=ZGxvubNQtIJS aYhBbNtzR8yZzS4axzHy64YyzNwhoC3vVUQ1PnDc1nELZaoNVA34wzq3D+EnimDf f68JigRRvfb+mxEQmbyDB0WrJUVuhTIeO9MhsQuCnhRBGExPiAC5AlvYnRuSyDR0 SNC72nJJh9N3MZXQQGVwkj3Gd/JuSLQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=rxtB0PyZ+5MWBV8wtF++yrjedBctCQpwdLEmN96z8 ks=; b=xCbP75EY+GNiRqrV09DEDzEJCRuQSbBPpwx0SBbTkSbnF4mrWblJcZhdo tK5WXNzbBi2oKb7zfw11AVgqJxh0757wHyKXVEEcBN+kKCNPExGTI8Q+lXALjTh2 9dCoxFf5w0T4ovKcNu6ewVa2iYy5SS4fnrEXrDPvLD2nUcaggngzCdTQqlBjEOXY sfpcXN6paf/NIPS7EpzALwmIgcNqgItuhlnysEQjg/XdEED3PuyMWaSjHHPgxvzP qWrevfjY5nAoYAVH5xQMmEvuafzWqsXBYLSO0CF1gxOhptTCSeMuh+tEAyw0XoG/ iE1XyLOHpUzwgDNXlu4vKPnNDaUIg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DCCD0102A0; Sun, 28 Oct 2018 06:21:47 -0400 (EDT) From: Thomas Monjalon To: Cody Doucette Cc: dev@dpdk.org, Gaetan Rivet , Konstantin Ananyev , Olivier Matz , Cristian Dumitrescu , michel@digirati.com.br, Qiaobin Fu , Konstantin Ananyev Date: Sun, 28 Oct 2018 11:21:53 +0100 Message-ID: <1549031.gagrcBMtR4@xps> In-Reply-To: <20180727135243.147744-1-doucette@bu.edu> References: <20180727135243.147744-1-doucette@bu.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2018 10:21:51 -0000 27/07/2018 15:52, Cody Doucette: > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > other IPv6 extension headers when finding the fragment header. > > According to RFC 8200, there is no guarantee that the IPv6 > Fragment extension header will come before any other extension > header, even though it is recommended. > > Signed-off-by: Cody Doucette > Signed-off-by: Qiaobin Fu > Reviewed-by: Michel Machado > --- > v3: > * Removed compilation flag D_XOPEN_SOURCE=700 from the > failsafe driver to allow compilation on freebsd. How failsafe is related to ip_frag? > v2: > * Moved IPv6 extension header definitions to lib_net. > > drivers/net/failsafe/Makefile | 1 - > drivers/net/failsafe/meson.build | 1 - > examples/ip_reassembly/main.c | 6 ++-- > lib/librte_ip_frag/rte_ip_frag.h | 23 ++++++------- > lib/librte_ip_frag/rte_ip_frag_version.map | 1 + > lib/librte_ip_frag/rte_ipv6_fragmentation.c | 38 +++++++++++++++++++++ > lib/librte_ip_frag/rte_ipv6_reassembly.c | 4 +-- > lib/librte_net/rte_ip.h | 27 +++++++++++++++ > lib/librte_port/rte_port_ras.c | 6 ++-- Changes in failsafe, rte_net and rte_port look like garbage. Anyway, the ip_frag part requires some review. +Cc Konstantin, the maintainer.