* [dpdk-dev] [PATCH v2] power: fix to remove unused variable
@ 2019-02-14 13:37 Pallantla Poornima
2019-02-14 15:17 ` Rami Rosen
2019-02-15 14:12 ` Aaron Conole
0 siblings, 2 replies; 3+ messages in thread
From: Pallantla Poornima @ 2019-02-14 13:37 UTC (permalink / raw)
To: dev; +Cc: reshma.pattan, david.hunt, aconole, Pallantla Poornima, stable
Variable pfi_str is removed since it is unused.
Fixes: 450f079131 ("power: add traffic pattern aware power control")
Cc: stable@dpdk.org
Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
---
v2: Removed unused variable as suggested.
---
lib/librte_power/rte_power_empty_poll.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c
index e6145462f..15d4f0509 100644
--- a/lib/librte_power/rte_power_empty_poll.c
+++ b/lib/librte_power/rte_power_empty_poll.c
@@ -156,11 +156,8 @@ update_training_stats(struct priority_worker *poll_stats,
{
RTE_SET_USED(specific_freq);
- char pfi_str[32];
uint64_t p0_empty_deq;
- sprintf(pfi_str, "%02d", freq);
-
if (poll_stats->cur_freq == freq &&
poll_stats->thresh[freq].trained == false) {
if (poll_stats->thresh[freq].cur_train_iter == 0) {
--
2.17.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v2] power: fix to remove unused variable
2019-02-14 13:37 [dpdk-dev] [PATCH v2] power: fix to remove unused variable Pallantla Poornima
@ 2019-02-14 15:17 ` Rami Rosen
2019-02-15 14:12 ` Aaron Conole
1 sibling, 0 replies; 3+ messages in thread
From: Rami Rosen @ 2019-02-14 15:17 UTC (permalink / raw)
To: Pallantla Poornima; +Cc: dev, reshma.pattan, david.hunt, aconole, stable
Hi,
I would suggest to consider to add:
Fixes: 450f0791312c ("power: add traffic pattern aware power control")
Reviewed-By: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v2] power: fix to remove unused variable
2019-02-14 13:37 [dpdk-dev] [PATCH v2] power: fix to remove unused variable Pallantla Poornima
2019-02-14 15:17 ` Rami Rosen
@ 2019-02-15 14:12 ` Aaron Conole
1 sibling, 0 replies; 3+ messages in thread
From: Aaron Conole @ 2019-02-15 14:12 UTC (permalink / raw)
To: Pallantla Poornima; +Cc: dev, reshma.pattan, david.hunt, aconole, stable
Pallantla Poornima <pallantlax.poornima@intel.com> writes:
> Variable pfi_str is removed since it is unused.
>
> Fixes: 450f079131 ("power: add traffic pattern aware power control")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> ---
Acked-by: Aaron Conole <aconole@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-15 14:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 13:37 [dpdk-dev] [PATCH v2] power: fix to remove unused variable Pallantla Poornima
2019-02-14 15:17 ` Rami Rosen
2019-02-15 14:12 ` Aaron Conole
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).