* [dpdk-dev] [PATCH v2] net/ice: faster bit check
@ 2019-02-15 18:07 Paul M Stillwell Jr
0 siblings, 0 replies; only message in thread
From: Paul M Stillwell Jr @ 2019-02-15 18:07 UTC (permalink / raw)
To: qi.z.zhang; +Cc: dev, Jesse Brandeburg, Paul M Stillwell Jr
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
Implement a slightly faster bit check, used for checking
descriptors in the hot path.
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
---
v2: fixed checkpatch issues
---
drivers/net/ice/ice_rxtx.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index c794ee8..7c82931 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -955,14 +955,13 @@
static inline uint64_t
ice_rxd_status_to_pkt_flags(uint64_t qword)
{
- uint64_t flags;
-
- /* Check if RSS_HASH */
- flags = (((qword >> ICE_RX_DESC_STATUS_FLTSTAT_S) &
- ICE_RX_DESC_FLTSTAT_RSS_HASH) ==
- ICE_RX_DESC_FLTSTAT_RSS_HASH) ? PKT_RX_RSS_HASH : 0;
-
- return flags;
+ static const uint64_t bitcheck =
+ (ICE_RX_DESC_FLTSTAT_RSS_HASH << ICE_RX_DESC_STATUS_FLTSTAT_S);
+ /* Check if RSS_HASH */
+ if ((qword & bitcheck) == bitcheck)
+ return PKT_RX_RSS_HASH;
+
+ return 0;
}
/* Rx L3/L4 checksum */
--
1.8.3.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-02-15 18:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-15 18:07 [dpdk-dev] [PATCH v2] net/ice: faster bit check Paul M Stillwell Jr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).