From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: olivier.matz@6wind.com, anatoly.burakov@intel.com,
ktraynor@redhat.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v3 1/2] eal: fix potential incorrect pinning for ctrl threads
Date: Tue, 19 Feb 2019 21:41:10 +0100 [thread overview]
Message-ID: <1550608871-5251-1-git-send-email-david.marchand@redhat.com> (raw)
In-Reply-To: <1550151042-9764-1-git-send-email-david.marchand@redhat.com>
pthread_setaffinity_np returns a >0 value on error.
We could end up letting the ctrl threads on the current process cpu
affinity.
Fixes: d651ee4919cd ("eal: set affinity for control threads")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changelog since v2:
- added missing Cc: stable@dpdk.org
---
lib/librte_eal/common/eal_common_thread.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
index 48ef4d6..a3985ce 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -209,7 +209,7 @@ static void *rte_thread_init(void *arg)
CPU_SET(rte_get_master_lcore(), &cpuset);
ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset);
- if (ret < 0)
+ if (ret)
goto fail;
ret = pthread_barrier_wait(¶ms->configured);
--
1.8.3.1
next prev parent reply other threads:[~2019-02-19 20:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 16:13 [dpdk-dev] [PATCH] eal: restrict ctrl threads to startup cpu affinity David Marchand
2019-02-13 20:21 ` David Marchand
2019-02-14 9:39 ` Burakov, Anatoly
2019-02-14 9:53 ` David Marchand
2019-02-14 10:04 ` Burakov, Anatoly
2019-02-14 10:16 ` David Marchand
2019-02-14 11:05 ` David Marchand
2019-02-14 13:30 ` [dpdk-dev] [PATCH v2 1/2] eal: fix potential incorrect pinning for ctrl threads David Marchand
2019-02-14 13:30 ` [dpdk-dev] [PATCH v2 2/2] eal: restrict ctrl threads to startup cpu affinity David Marchand
2019-02-19 11:38 ` Burakov, Anatoly
2019-02-19 11:51 ` David Marchand
2019-02-19 16:03 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-02-14 16:12 ` [dpdk-dev] [PATCH v2 1/2] eal: fix potential incorrect pinning for ctrl threads Burakov, Anatoly
2019-02-14 17:45 ` David Marchand
2019-02-19 20:41 ` David Marchand [this message]
2019-02-19 20:41 ` [dpdk-dev] [PATCH v3 2/2] eal: restrict ctrl threads to startup cpu affinity David Marchand
2019-02-20 16:01 ` Burakov, Anatoly
2019-02-25 8:33 ` Olivier Matz
2019-03-07 18:23 ` Thomas Monjalon
2019-02-20 16:01 ` [dpdk-dev] [PATCH v3 1/2] eal: fix potential incorrect pinning for ctrl threads Burakov, Anatoly
2019-02-25 8:33 ` Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550608871-5251-1-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).