From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 5B1AA590C
 for <dev@dpdk.org>; Fri, 31 Oct 2014 10:15:34 +0100 (CET)
Received: by mail-wg0-f45.google.com with SMTP id x12so6071289wgg.32
 for <dev@dpdk.org>; Fri, 31 Oct 2014 02:24:34 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=ReKgOEEB22CYCuhX7dPNSG5BUsUWI5wXYeIPiIN9lDk=;
 b=L2lCSvvr/j0Wwk2ZvKxNHRuuEzkUMffjD86F4lXCm4EwRQKwivVdTRaZCgzTVNxt3s
 5GpXjf67ZNsC1AqPDrMe1lrnXb2Ga3UdIJ7NQE4TT0ZD/8r5QhBsZyGyb5Ie+ICQGH3b
 sU2P/vpzIfTGmx4ZMfRaJXwwbpRUhd3uIFtTU7eFgTtye4YslbyoJlz5IdFCcx+09tFK
 vF9g+2Qy2f9CMiTuvSjAKT9L9ouEoTL6UJq4Bq7X1vgGzHvBzIlRmL5tdrNSLIFczX0G
 7C6D9rKf+2Kl5v3vuuHxJD6dxi2jLlXDKsgu3165bw75fKJR5ImEZahGD4Ii1CI/YzoZ
 IT1w==
X-Gm-Message-State: ALoCoQlhQfrgt1ScUmAoWfgtrisrTrmcg0l/lQ/XHusPjpOEyrtmrIg6GLOmt+9/S1tPSuzxPjrZ
X-Received: by 10.194.243.164 with SMTP id wz4mr1075901wjc.129.1414747474087; 
 Fri, 31 Oct 2014 02:24:34 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id gy4sm5477568wib.11.2014.10.31.02.24.33
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 31 Oct 2014 02:24:33 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Date: Fri, 31 Oct 2014 10:24:15 +0100
Message-ID: <1550663.1Z4EX83Uic@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; )
In-Reply-To: <1414722382-14807-1-git-send-email-jijiang.liu@intel.com>
References: <1414722382-14807-1-git-send-email-jijiang.liu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_ether:change rte_eth_mac_filter
	structure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Oct 2014 09:15:34 -0000

2014-10-31 10:26, Jijiang Liu:
> As the filter type in i40e is defined enum type, so this patch changes
> the filter_type filed in the rte_eth_mac_filter for fixing the compilation
> error under ICC compiler. 

Commit log is wrong. It's not because of i40e, it's only an API problem.
But I know you mix i40e and generic API.

> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>

> --- a/lib/librte_ether/rte_eth_ctrl.h
> +++ b/lib/librte_ether/rte_eth_ctrl.h
> @@ -91,7 +91,7 @@ enum rte_mac_filter_type {
>  struct rte_eth_mac_filter {
>  	uint8_t is_vf; /**< 1 for VF, 0 for port dev */
>  	uint16_t dst_id; /**<VF ID, available when is_vf is 1*/
> -	uint16_t filter_type; /**< MAC filter type */
> +	enum rte_mac_filter_type filter_type; /**< MAC filter type */
>  	struct ether_addr mac_addr;
>  };

I didn't catch this error during my review. That's why we need more eyes to
carefully review patches.

Acked and applied

Thanks
-- 
Thomas