[dpdk-dev] [PATCH] librte_ether:change rte_eth_mac_filter structure

[dpdk-dev] [PATCH] librte_ether:change rte_eth_mac_filter structure

[Jijiang Liu]

As the filter type in i40e is defined enum type, so this patch changes the filter_type filed in the rte_eth_mac_filter for fixing the compilation error under ICC compiler. 

Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
---
 lib/librte_ether/rte_eth_ctrl.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h
index 14a739b..91a6b64 100644
--- a/lib/librte_ether/rte_eth_ctrl.h
+++ b/lib/librte_ether/rte_eth_ctrl.h
@@ -91,7 +91,7 @@ enum rte_mac_filter_type {
 struct rte_eth_mac_filter {
 	uint8_t is_vf; /**< 1 for VF, 0 for port dev */
 	uint16_t dst_id; /**<VF ID, available when is_vf is 1*/
-	uint16_t filter_type; /**< MAC filter type */
+	enum rte_mac_filter_type filter_type; /**< MAC filter type */
 	struct ether_addr mac_addr;
 };
 
-- 
1.7.7.6

Re: [dpdk-dev] [PATCH] librte_ether:change rte_eth_mac_filter structure

[Thomas Monjalon]

2014-10-31 10:26, Jijiang Liu:
> As the filter type in i40e is defined enum type, so this patch changes
> the filter_type filed in the rte_eth_mac_filter for fixing the compilation
> error under ICC compiler. 

Commit log is wrong. It's not because of i40e, it's only an API problem.
But I know you mix i40e and generic API.

> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>

> --- a/lib/librte_ether/rte_eth_ctrl.h
> +++ b/lib/librte_ether/rte_eth_ctrl.h
> @@ -91,7 +91,7 @@ enum rte_mac_filter_type {
>  struct rte_eth_mac_filter {
>  	uint8_t is_vf; /**< 1 for VF, 0 for port dev */
>  	uint16_t dst_id; /**<VF ID, available when is_vf is 1*/
> -	uint16_t filter_type; /**< MAC filter type */
> +	enum rte_mac_filter_type filter_type; /**< MAC filter type */
>  	struct ether_addr mac_addr;
>  };

I didn't catch this error during my review. That's why we need more eyes to
carefully review patches.

Acked and applied

Thanks
-- 
Thomas