From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <david.marchand@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id DEFB95920;
Mon, 4 Mar 2019 12:19:19 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
[10.5.11.14])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 4EE1C308424E;
Mon, 4 Mar 2019 11:19:19 +0000 (UTC)
Received: from dmarchan.remote.csb (ovpn-204-16.brq.redhat.com [10.40.204.16])
by smtp.corp.redhat.com (Postfix) with ESMTP id 26D7E5D9CA;
Mon, 4 Mar 2019 11:19:17 +0000 (UTC)
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: stable@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>
Date: Mon, 4 Mar 2019 12:18:33 +0100
Message-Id: <1551698315-2611-11-git-send-email-david.marchand@redhat.com>
In-Reply-To: <1551698315-2611-1-git-send-email-david.marchand@redhat.com>
References: <1551698315-2611-1-git-send-email-david.marchand@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.40]); Mon, 04 Mar 2019 11:19:19 +0000 (UTC)
Subject: [dpdk-dev] [PATCH 10/12] net/ring: fix incorrect rxq errors stat
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Mar 2019 11:19:20 -0000
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: e1e4017751f1 ("ring: add new driver")
Cc: stable@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/ring/rte_eth_ring.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index aeb48f5..4865763 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -182,9 +182,8 @@ struct pmd_internals {
for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&
i < dev->data->nb_tx_queues; i++) {
stats->q_opackets[i] = internal->tx_ring_queues[i].tx_pkts.cnt;
- stats->q_errors[i] = internal->tx_ring_queues[i].err_pkts.cnt;
tx_total += stats->q_opackets[i];
- tx_err_total += stats->q_errors[i];
+ tx_err_total += internal->tx_ring_queues[i].err_pkts.cnt;
}
stats->ipackets = rx_total;
--
1.8.3.1