From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, "John W. Linville" <linville@tuxdriver.com>
Subject: [dpdk-dev] [PATCH 01/12] net/af_packet: fix incorrect rxq errors stat
Date: Mon, 4 Mar 2019 12:18:24 +0100 [thread overview]
Message-ID: <1551698315-2611-2-git-send-email-david.marchand@redhat.com> (raw)
In-Reply-To: <1551698315-2611-1-git-send-email-david.marchand@redhat.com>
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PACKET-based virtual devices")
Cc: stable@dpdk.org
Cc: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/af_packet/rte_eth_af_packet.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
index 264cfc0..ec90cc0 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -328,10 +328,9 @@ struct pmd_internals {
internal->nb_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS);
for (i = 0; i < imax; i++) {
igb_stats->q_opackets[i] = internal->tx_queue[i].tx_pkts;
- igb_stats->q_errors[i] = internal->tx_queue[i].err_pkts;
igb_stats->q_obytes[i] = internal->tx_queue[i].tx_bytes;
tx_total += igb_stats->q_opackets[i];
- tx_err_total += igb_stats->q_errors[i];
+ tx_err_total += internal->tx_queue[i].err_pkts;
tx_bytes_total += igb_stats->q_obytes[i];
}
--
1.8.3.1
next prev parent reply other threads:[~2019-03-04 11:19 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 11:18 [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes David Marchand
2019-03-04 11:18 ` David Marchand [this message]
2019-03-04 11:18 ` [dpdk-dev] [PATCH 02/12] net/avp: fix incorrect rxq errors stat David Marchand
2019-03-04 12:18 ` Legacy, Allain
2019-03-04 11:18 ` [dpdk-dev] [PATCH 03/12] net/bnxt: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 04/12] net/cxgbe: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 05/12] net/kni: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 06/12] net/mlx4: " David Marchand
2019-03-05 8:19 ` Shahaf Shuler
2019-03-04 11:18 ` [dpdk-dev] [PATCH 07/12] net/mlx5: " David Marchand
2019-03-05 8:18 ` Shahaf Shuler
2019-03-04 11:18 ` [dpdk-dev] [PATCH 08/12] net/null: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 09/12] net/pcap: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 10/12] net/ring: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 11/12] net/szedata2: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 12/12] net/tap: " David Marchand
2019-03-04 13:58 ` Wiles, Keith
2019-03-11 17:22 ` [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes Ferruh Yigit
2019-03-11 18:09 ` David Marchand
2019-03-14 15:12 ` David Marchand
2019-03-14 15:12 ` David Marchand
2019-03-14 15:13 ` [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API David Marchand
2019-03-14 15:13 ` David Marchand
2019-03-14 15:13 ` [dpdk-dev] [RFC PATCH 2/2] net/af_packet: convert to new " David Marchand
2019-03-14 15:13 ` David Marchand
2019-03-15 13:30 ` [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal " David Marchand
2019-03-15 13:30 ` David Marchand
2019-03-19 17:18 ` Ferruh Yigit
2019-03-19 17:18 ` Ferruh Yigit
2019-03-19 17:54 ` Stephen Hemminger
2019-03-19 17:54 ` Stephen Hemminger
2019-04-12 13:18 ` Thomas Monjalon
2019-04-12 13:18 ` Thomas Monjalon
2019-03-26 9:29 ` David Marchand
2019-03-26 9:29 ` David Marchand
2019-04-12 13:29 ` Thomas Monjalon
2019-04-12 13:29 ` Thomas Monjalon
2019-04-12 14:32 ` David Marchand
2019-04-12 14:32 ` David Marchand
2019-04-12 16:05 ` Stephen Hemminger
2019-04-12 16:05 ` Stephen Hemminger
2019-04-12 15:07 ` [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes Thomas Monjalon
2019-04-12 15:07 ` Thomas Monjalon
2019-04-12 15:38 ` Ferruh Yigit
2019-04-12 15:38 ` Ferruh Yigit
2019-04-12 15:45 ` Thomas Monjalon
2019-04-12 15:45 ` Thomas Monjalon
2019-04-12 15:57 ` Ferruh Yigit
2019-04-12 15:57 ` Ferruh Yigit
2019-05-28 21:38 ` Yigit, Ferruh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551698315-2611-2-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).