DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] meson: fix building subdirectories separately
@ 2019-03-05 16:29 Andrius Sirvys
  2019-03-05 17:21 ` Bruce Richardson
  2019-03-07  9:56 ` [dpdk-dev] [PATCH v3] build: move variable definition to top level Andrius Sirvys
  0 siblings, 2 replies; 13+ messages in thread
From: Andrius Sirvys @ 2019-03-05 16:29 UTC (permalink / raw)
  To: bruce.richardson; +Cc: dev, Andrius Sirvys

If for debugging we disable the driver directory in the meson.build file,
we get an error because the variable "driver_classes" does not exist.
This is because driver_classes is only defined in the
drivers/meson.build file. Defining driver_classes in dpdk/meson.build file
will make it easier for compiling separate directories.

In the process, we rename driver_classes to dpdk_driver_classes for
consistency with the other variables.

Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
---
v2: Fixed mispellings in commit message
---
 drivers/meson.build | 4 ++--
 meson.build         | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/meson.build b/drivers/meson.build
index c3c66bb..ebe1104 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -2,7 +2,7 @@
 # Copyright(c) 2017 Intel Corporation
 
 # Defines the order in which the drivers are buit.
-driver_classes = ['common',
+dpdk_driver_classes = ['common',
 	       'bus',
 	       'mempool', # depends on common and bus.
 	       'net',     # depends on common, bus and mempool.
@@ -20,7 +20,7 @@ endif
 # specify -D_GNU_SOURCE unconditionally
 default_cflags += '-D_GNU_SOURCE'
 
-foreach class:driver_classes
+foreach class:dpdk_driver_classes
 	drivers = []
 	std_deps = []
 	config_flag_fmt = '' # format string used to set the value in dpdk_conf
diff --git a/meson.build b/meson.build
index 7f5e867..7785251 100644
--- a/meson.build
+++ b/meson.build
@@ -13,6 +13,7 @@ cc = meson.get_compiler('c')
 dpdk_conf = configuration_data()
 dpdk_libraries = []
 dpdk_static_libraries = []
+dpdk_driver_classes = []
 dpdk_drivers = []
 dpdk_extra_ldflags = []
 dpdk_app_link_libraries = []
@@ -110,7 +111,7 @@ message(output_message + '\n')
 # track driver lists easily
 if meson.version().version_compare('>=0.47')
 	output_message = '\n===============\nDrivers Enabled\n===============\n'
-	foreach class:driver_classes
+	foreach class:dpdk_driver_classes
 		class_drivers = get_variable(class + '_drivers')
 		output_message += '\n' + class + ':\n\t'
 		output_count = 0
-- 
2.7.4

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-03-26 22:16 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-05 16:29 [dpdk-dev] [PATCH v2] meson: fix building subdirectories separately Andrius Sirvys
2019-03-05 17:21 ` Bruce Richardson
2019-03-05 17:26   ` Bruce Richardson
2019-03-05 18:01     ` Ranjit Menon
2019-03-07  9:56 ` [dpdk-dev] [PATCH v3] build: move variable definition to top level Andrius Sirvys
2019-03-07 10:18   ` Bruce Richardson
2019-03-07 11:28   ` [dpdk-dev] [PATCH v4] " Andrius Sirvys
2019-03-24 22:59     ` Thomas Monjalon
2019-03-24 22:59       ` Thomas Monjalon
2019-03-25 10:34     ` [dpdk-dev] [PATCH v5] " Andrius Sirvys
2019-03-25 10:34       ` Andrius Sirvys
2019-03-26 22:16       ` Thomas Monjalon
2019-03-26 22:16         ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).