From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id C5F5D936A
 for <dev@dpdk.org>; Sun,  6 Dec 2015 22:35:12 +0100 (CET)
Received: by wmww144 with SMTP id w144so127387950wmw.0
 for <dev@dpdk.org>; Sun, 06 Dec 2015 13:35:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding
 :content-type; bh=AiAh2OxLoSK6pXh9EqGgY6jlp5nUVDajBVHqoaqkTRk=;
 b=R4YyWXi8vbW4k8rf7MHAYa/dk8lemMXSgdoKmn4He7+FWVhg6/KulDkjmrD7yJBlpJ
 0m8Z0rKt2hdzSmz8Yyf61rhPT/lnQxE/nO44MYyTLjnoHZk/I73BU8vvcZuLyo0pxeKU
 0qNa7ucdEbkZJVFxitLDfvQMXMopnFbiC+OVDS5tdOUGvnBDuiBXeP0VNXmLlLaOMOxZ
 IsZcBRdFJbAGUivghKxsdCTE14plwunbdff7oIUsMYrO6vfLJKHRu54/LOAgQuJTR54Y
 7GMfEICOTGzDIGNoCtdPbXW2+fROB2uKIg5f6bxc8ltsfnS/taC+IKBEO2in7hb5KOc9
 ajQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=AiAh2OxLoSK6pXh9EqGgY6jlp5nUVDajBVHqoaqkTRk=;
 b=AlaA2YI5s71Cym1m++hquHuEnP9P7ulCG9GyevWJjDAlGY3H47kYKxGElkumLPstW+
 Ma275J5osSE4Uixr+8k6gAvVbULqCdVsdQ2+ks2S6Tcb9vBCeUl4Y4Oaw94UnTgGNzch
 sx9gSFbefeuI+kvaXGJYplpz1d5K9ZY9Zs1NAg2FxLJsMQISsldrR8zuEwiv4rOr2HzJ
 KX0I1qFjXkNYAaCJCQNaUQX38JCpGY2pyU7kHq2G3GHsI2hYmzFWGjIKXPNvIdvFyvU2
 tcA+kBPh3y4vQ85vXEdXt2gRtcuBh1eCkmtJ+5CMw5l4fB5aEs6brXHl/THTDpa1kgMv
 01Fw==
X-Gm-Message-State: ALoCoQla9p80IKDxsNZBDfAYt9UZaAMRem58ScxYYXNQTrd9xvYatdT8ku/2DFtBFcqPndWjnWMh
X-Received: by 10.28.90.132 with SMTP id o126mr18587360wmb.1.1449437712658;
 Sun, 06 Dec 2015 13:35:12 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id b84sm13566568wmh.15.2015.12.06.13.35.11
 (version=TLSv1/SSLv3 cipher=OTHER);
 Sun, 06 Dec 2015 13:35:12 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Sun, 06 Dec 2015 22:34:01 +0100
Message-ID: <1552305.QY8GdKH3cv@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <20151130083300.75ba06bc@xeon-e3>
References: <1448855649-24658-1-git-send-email-jingjing.wu@intel.com>
 <20151130083300.75ba06bc@xeon-e3>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40evf: fix mac deletion when stop dev
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Dec 2015 21:35:13 -0000

2015-11-30 08:33, Stephen Hemminger:
> On Mon, 30 Nov 2015 11:54:09 +0800
> Jingjing Wu <jingjing.wu@intel.com> wrote:
> 
> > +	(void)rte_memcpy(mac_addr.addr_bytes, hw->mac.addr,
> > +				sizeof(mac_addr.addr_bytes))
> 
> Please don't add useless (void) cast.
> I haven't seen that since lint on Unix.

It is the style in i40e driver.
It may deserve a general cleanup.