From: Andrius Sirvys <andrius.sirvys@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, Andrius Sirvys <andrius.sirvys@intel.com>,
bruce.richardson@intel.com
Subject: [dpdk-dev] [PATCH v2] acl: fix missing flags when compiling without AVX2
Date: Mon, 11 Mar 2019 15:18:11 +0000 [thread overview]
Message-ID: <1552317491-161841-1-git-send-email-andrius.sirvys@intel.com> (raw)
When compiling the ACL library on a system without AVX2 support,
the flags used to compile the AVX2-specific code for later run-time
use were not based on the regular cflags for the rest of the library.
This can cause errors due to symbols being missed/undefined
due to incorrect flags. For example,
when testing compilation on Alpine linux, we got:
error: unknown type name 'cpu_set_t'
due to _GNU_SOURCE not being defined in the cflags.
This issue can be fixed by appending "-mavx2" to
the cflags rather than replacing them with it.
Fixes: 5b9656b157d3 ("lib: build with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
---
Cc: bruce.richardson@intel.com
v2: fixed spelling errors in code
---
lib/librte_acl/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_acl/meson.build b/lib/librte_acl/meson.build
index aec792f..58d346a 100644
--- a/lib/librte_acl/meson.build
+++ b/lib/librte_acl/meson.build
@@ -23,7 +23,7 @@ if arch_subdir == 'x86'
avx2_tmplib = static_library('avx2_tmp',
'acl_run_avx2.c',
dependencies: static_rte_eal,
- c_args: '-mavx2')
+ c_args: cflags + ['-mavx2'])
objs += avx2_tmplib.extract_objects('acl_run_avx2.c')
cflags += '-DCC_AVX2_SUPPORT'
endif
--
2.7.4
next reply other threads:[~2019-03-11 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 15:18 Andrius Sirvys [this message]
2019-03-11 16:31 ` Bruce Richardson
2019-03-27 9:39 ` Thomas Monjalon
2019-03-27 9:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552317491-161841-1-git-send-email-andrius.sirvys@intel.com \
--to=andrius.sirvys@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).