From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 452DE4CA9; Wed, 20 Mar 2019 11:02:57 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6439288ABB; Wed, 20 Mar 2019 10:02:56 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com [10.40.204.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9726E5D9D2; Wed, 20 Mar 2019 10:02:53 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, ramirose@gmail.com, arybchenko@solarflare.com, stable@dpdk.org Date: Wed, 20 Mar 2019 11:02:31 +0100 Message-Id: <1553076154-3907-2-git-send-email-david.marchand@redhat.com> In-Reply-To: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> References: <1552318522-18777-1-git-send-email-david.marchand@redhat.com> <1553076154-3907-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 20 Mar 2019 10:02:56 +0000 (UTC) Subject: [dpdk-dev] [PATCH v3 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 10:02:57 -0000 Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] After: RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: David Marchand Reviewed-by: Rami Rosen --- Changelog since v2: - Cc'd stable --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index d9d0c16..78206f6 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1459,7 +1459,7 @@ struct extmem_param { "TX Port=%2d/Queue=%2d %s\n", fwd_top_stats_border, fs->rx_port, fs->rx_queue, fs->tx_port, fs->tx_queue, fwd_top_stats_border); - printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u", + printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n", fs->rx_packets, fs->tx_packets, fs->fwd_dropped); /* if checksum mode */ -- 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EB5B4A00E6 for ; Wed, 20 Mar 2019 11:03:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74E6C4CBD; Wed, 20 Mar 2019 11:02:58 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 452DE4CA9; Wed, 20 Mar 2019 11:02:57 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6439288ABB; Wed, 20 Mar 2019 10:02:56 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com [10.40.204.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9726E5D9D2; Wed, 20 Mar 2019 10:02:53 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, ramirose@gmail.com, arybchenko@solarflare.com, stable@dpdk.org Date: Wed, 20 Mar 2019 11:02:31 +0100 Message-Id: <1553076154-3907-2-git-send-email-david.marchand@redhat.com> In-Reply-To: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> References: <1552318522-18777-1-git-send-email-david.marchand@redhat.com> <1553076154-3907-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 20 Mar 2019 10:02:56 +0000 (UTC) Subject: [dpdk-dev] [PATCH v3 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190320100231._EqCTFkOpDLu6_dyO_2IF34cjADjkwM1t6hn9upGUlQ@z> Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] After: RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: David Marchand Reviewed-by: Rami Rosen --- Changelog since v2: - Cc'd stable --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index d9d0c16..78206f6 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1459,7 +1459,7 @@ struct extmem_param { "TX Port=%2d/Queue=%2d %s\n", fwd_top_stats_border, fs->rx_port, fs->rx_queue, fs->tx_port, fs->tx_queue, fwd_top_stats_border); - printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u", + printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n", fs->rx_packets, fs->tx_packets, fs->fwd_dropped); /* if checksum mode */ -- 1.8.3.1