From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DF3AA2A6C; Mon, 21 May 2018 18:40:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7EEFD22426; Mon, 21 May 2018 12:40:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 21 May 2018 12:40:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=BrLzHG4G6qye3QE1oCnXB9ntbh VF9OnXrs/Srzcv300=; b=qrXsKbD/nU1f6chKpBXGwWtgwZDiI04LoNoF1Mry8p 8h/67LGClrUkO/e1U6kGWcbvVqFQFQZl+Reym8kXFX44ZTw6T8VOV1749rCDqDtH U68PeRsijZ9uaMFulascT40P/jb7bLjmJXzcAOJsImHHvvKWtlP1uA+HAD7ZHOWv 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=BrLzHG 4G6qye3QE1oCnXB9ntbhVF9OnXrs/Srzcv300=; b=VLUue/V1+AebsEDbsf3s3t zR/L8ZfQLBI1IhJnmE1DedwZ9Aa+0VAdzcCyop8AfObKSGBq1BRZ1E4a97grrFGA hJCUm166Whxydb4CWOLNGn4oZZheKP7IqTz7uepF5hj5wT0hlkmBErBLZFYg0GCD 9IxjPmotn0RQzRgPlDJjHKno7RKCAlKhVnno88inp3sDg++ielZA2agQWU0eAoH8 3Q9YRYBNA9dZBSDIMQvnVQWVw/sHQUiEVzs5/1yT1Vou77zmj2LHgsTgA8Af0hql KkX3yqRPD854ry+O2ko/B40lM8md+Kw2BEAvOvTzQjOEZVH2/H5lBjGhkrSjtUmw == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (236.204.154.77.rev.sfr.net [77.154.204.236]) by mail.messagingengine.com (Postfix) with ESMTPA id E20351026E; Mon, 21 May 2018 12:40:53 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Matan Azrad , "Iremonger, Bernard" , "Yao, Lei A" , "Yang, Zhiyong" , "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "Bie, Tiwei" , "stable@dpdk.org" , Harry Van Haaren Date: Mon, 21 May 2018 18:40:51 +0200 Message-ID: <1553952.sZOlap8oeX@xps> In-Reply-To: <5de1b87d-fcc5-c33c-f9a3-6e879b6c17fd@intel.com> References: <20180518095937.28710-1-zhiyong.yang@intel.com> <2140651.lW3kzKMLfn@xps> <5de1b87d-fcc5-c33c-f9a3-6e879b6c17fd@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 16:40:57 -0000 21/05/2018 18:37, Ferruh Yigit: > On 5/19/2018 3:19 PM, Thomas Monjalon wrote: > > 18/05/2018 18:29, Ferruh Yigit: > >> On 5/18/2018 4:55 PM, Matan Azrad wrote: > >>> Hi all > >>> > >>> While this patch also applied I don't understand it. > >>> Is it mandatory for each PMD to free all its resources in dev_close()? > >>> Or it should be done by the rte_device remove function? > >>> > >>> If the resource cleanup should be done by the remove function I think it > >>> should be called for all the devices (pci, vdev, etc). > >>> > >>> Is there an exit function for EAL to clean rte_eal_init()? If no, looks like we need it... > >> > >> Hi Matan, > >> > >> I believe there is a gap in resource cleanup. > >> dev_close() it not for resource cleanup, it should be in PMD remove() functions, > >> and PMDs have it. The problem is remove path is not called in application exit. > >> > >> As far as I know there is no simple API to clean the resources, having it may > >> help application to do the cleanup. > >> > >> I have seen the rte_eal_cleanup() API by Harry, that can be extended to cover > >> PMD resource cleanup if there is enough motivation for it. > > > > Yes, EAL resources should be removed by the function rte_eal_cleanup(). > > And ethdev ports must be removed by rte_eth_dev_close(). > > There is probe() and remove() functions. > There is dev_close devops, called by rte_eth_dev_close(), but there is no open() > or equivalent. > > For example an ethdev allocated its private data during probe(), if > rte_eth_dev_close() free it, how can a new ethdev can be allocated? I don't understand the question. You say closing a port and opening a new one. So we allocate private data in the new probe.