From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 7A7F94CC7; Mon, 8 Apr 2019 15:54:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 06:54:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,325,1549958400"; d="scan'208";a="162418028" Received: from silpixa00380299.ir.intel.com ([10.237.223.210]) by fmsmga001.fm.intel.com with ESMTP; 08 Apr 2019 06:54:42 -0700 From: Andrius Sirvys To: dev@dpdk.org Cc: kevin.laatz@intel.com, stable@dpdk.org, Andrius Sirvys , ciara.power@intel.com Date: Mon, 8 Apr 2019 14:54:41 +0100 Message-Id: <1554731681-98256-1-git-send-email-andrius.sirvys@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <11554730848-97709-1-git-send-email-andrius.sirvys@intel.com> References: <11554730848-97709-1-git-send-email-andrius.sirvys@intel.com> Subject: [dpdk-dev] [PATCH v3] usertools: replace unsafe input function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2019 13:54:46 -0000 LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.power@intel.com Signed-off-by: Andrius Sirvys Acked-by: Kevin Laatz --- v3: Included omitted code --- usertools/dpdk-telemetry-client.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py index ce0c7a9..17b4daa 100755 --- a/usertools/dpdk-telemetry-client.py +++ b/usertools/dpdk-telemetry-client.py @@ -14,6 +14,11 @@ API_UNREG = "{\"action\":2,\"command\":\"clients\",\"data\":{\"client_path\":\"" DEFAULT_FP = "/var/run/dpdk/default_client" +try: + raw_input # Python 2 +except NameError: + raw_input = input # Python 3 + class Socket: def __init__(self): @@ -72,7 +77,7 @@ def requestMetrics(self): # Requests metrics for given client def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client print("\nPlease enter the number of times you'd like to continuously request Metrics:") - n_requests = int(input("\n:")) + n_requests = int(ast.literal_eval(raw_input("\n:"))) print("\033[F") #Removes the user input from screen, cleans it up print("\033[K") for i in range(n_requests): @@ -87,7 +92,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr print("[3] Unregister client") try: - self.choice = int(input("\n:")) + self.choice = int(ast.literal_eval(raw_input("\n:"))) print("\033[F") #Removes the user input for screen, cleans it up print("\033[K") if self.choice == 1: -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2660FA0096 for ; Mon, 8 Apr 2019 15:54:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C12D24F94; Mon, 8 Apr 2019 15:54:47 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 7A7F94CC7; Mon, 8 Apr 2019 15:54:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 06:54:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,325,1549958400"; d="scan'208";a="162418028" Received: from silpixa00380299.ir.intel.com ([10.237.223.210]) by fmsmga001.fm.intel.com with ESMTP; 08 Apr 2019 06:54:42 -0700 From: Andrius Sirvys To: dev@dpdk.org Cc: kevin.laatz@intel.com, stable@dpdk.org, Andrius Sirvys , ciara.power@intel.com Date: Mon, 8 Apr 2019 14:54:41 +0100 Message-Id: <1554731681-98256-1-git-send-email-andrius.sirvys@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <11554730848-97709-1-git-send-email-andrius.sirvys@intel.com> References: <11554730848-97709-1-git-send-email-andrius.sirvys@intel.com> Subject: [dpdk-dev] [PATCH v3] usertools: replace unsafe input function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190408135441.V5VDcXNgFL1JByF5ntVEwuTxkfLz1WGQzqlrIP3VLTI@z> LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.power@intel.com Signed-off-by: Andrius Sirvys Acked-by: Kevin Laatz --- v3: Included omitted code --- usertools/dpdk-telemetry-client.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py index ce0c7a9..17b4daa 100755 --- a/usertools/dpdk-telemetry-client.py +++ b/usertools/dpdk-telemetry-client.py @@ -14,6 +14,11 @@ API_UNREG = "{\"action\":2,\"command\":\"clients\",\"data\":{\"client_path\":\"" DEFAULT_FP = "/var/run/dpdk/default_client" +try: + raw_input # Python 2 +except NameError: + raw_input = input # Python 3 + class Socket: def __init__(self): @@ -72,7 +77,7 @@ def requestMetrics(self): # Requests metrics for given client def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client print("\nPlease enter the number of times you'd like to continuously request Metrics:") - n_requests = int(input("\n:")) + n_requests = int(ast.literal_eval(raw_input("\n:"))) print("\033[F") #Removes the user input from screen, cleans it up print("\033[K") for i in range(n_requests): @@ -87,7 +92,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr print("[3] Unregister client") try: - self.choice = int(input("\n:")) + self.choice = int(ast.literal_eval(raw_input("\n:"))) print("\033[F") #Removes the user input for screen, cleans it up print("\033[K") if self.choice == 1: -- 2.7.4